Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jan 1999 18:00:54 -0800 (PST)
From:      Archie Cobbs <archie@whistle.com>
To:        dillon@apollo.backplane.com (Matthew Dillon)
Cc:        current@FreeBSD.ORG
Subject:   Re: btokup() macro in sys/malloc.h
Message-ID:  <199901280200.SAA19958@bubba.whistle.com>
In-Reply-To: <199901280045.QAA77982@apollo.backplane.com> from Matthew Dillon at "Jan 27, 99 04:45:31 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon writes:
> :> #define btokup(addr)    (&kmemusage[((caddr_t)(addr) - kmembase) >> PAGE_SHIFT])
> :
> :The added parentheses don't make any difference, semantically.  This
> :change probably wouldn't meet the criteria spelled out in style(9):
> 
>     Then style(9) needs to be updated, because we have to add parenthesis
>     to be able to not get warnings with -Wall.

Please do go ahead and update it.. the experts agree!

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280200.SAA19958>