From owner-freebsd-current@FreeBSD.ORG  Thu Jul 24 11:18:43 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B31DE37B401
	for <current@freebsd.org>; Thu, 24 Jul 2003 11:18:43 -0700 (PDT)
Received: from pool-151-200-10-97.res.east.verizon.net
	(pool-138-88-153-11.esr.east.verizon.net [138.88.153.11])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AB08543F85
	for <current@freebsd.org>; Thu, 24 Jul 2003 11:18:42 -0700 (PDT)
	(envelope-from mtm@identd.net)
Received: from kokeb.ambesa.net (n4lu0wt417h1fc7z@localhost [127.0.0.1])
	id h6OIIe61001181
	for <current@freebsd.org>; Thu, 24 Jul 2003 14:18:40 -0400 (EDT)
	(envelope-from mtm@identd.net)
Received: (from mtm@localhost)
	by kokeb.ambesa.net (8.12.9/8.12.9/Submit) id h6OIIc36001180
	for current@freebsd.org; Thu, 24 Jul 2003 14:18:38 -0400 (EDT)
	(envelope-from mtm@identd.net)
X-Authentication-Warning: kokeb.ambesa.net: mtm set sender to mtm@identd.net
	using -f
Date: Thu, 24 Jul 2003 14:18:37 -0400
From: Mike Makonnen <mtm@identd.net>
To: current@freebsd.org
Message-ID: <20030724181836.GA980@kokeb.ambesa.net>
References: <20030724165938.GA2876@node1.cluster.srrc.usda.gov>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="UlVJffcvxoiEqYs2"
Content-Disposition: inline
In-Reply-To: <20030724165938.GA2876@node1.cluster.srrc.usda.gov>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD/5.1-CURRENT (i386)
Subject: Re: syntax problem with /etc/rc.d/nfslocking
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jul 2003 18:18:44 -0000


--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Thanks! I just committed a fix (reproduced here for
your convenience).

Cheers.
-- 
Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
mtm@identd.net | D228 1A6F C64E 120A A1C9  A3AA DAE1 E2AF DBCC 68B9
mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon!

--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="rcsubr.diff"

Index: etc/rc.subr
===================================================================
RCS file: /home/ncvs/src/etc/rc.subr,v
retrieving revision 1.13
diff -u -r1.13 rc.subr
--- etc/rc.subr	9 Jun 2003 17:31:06 -0000	1.13
+++ etc/rc.subr	24 Jul 2003 18:15:02 -0000
@@ -669,7 +669,7 @@
 					# if the precmd failed and force
 					# isn't set, exit
 					#
-			if [ -n $_precmd ]; then
+			if [ -n "$_precmd" ]; then
 				eval $_precmd
 				_return=$?
 				[ $_return -ne 0 ] && [ -z "$rc_force" ] &&

--UlVJffcvxoiEqYs2--