Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Aug 2022 21:33:47 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: 05c9a0158f68 - main - libc: Add strverscmp(3) and versionsort(3)
Message-ID:  <20220825213347.GA89898@spindle.one-eyed-alien.net>
In-Reply-To: <YwbO8Na3k0BpvWmn@kib.kiev.ua>
References:  <202208250029.27P0TRwK091769@gitrepo.freebsd.org> <FFCE6298-AF3B-4B50-B1C1-B4E01F604B30@freebsd.org> <YwbO8Na3k0BpvWmn@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 25, 2022 at 04:22:56AM +0300, Konstantin Belousov wrote:
> On Thu, Aug 25, 2022 at 02:07:12AM +0100, Jessica Clarke wrote:
> > On 25 Aug 2022, at 01:29, Konstantin Belousov <kib@FreeBSD.org> wrote:
> > > +	const unsigned char *u1 =3D __DECONST(const unsigned char *, s1);
> > > +	const unsigned char *u2 =3D __DECONST(const unsigned char *, s2);
> >=20
> > Why is __DECONST needed? Casting from const char * to const unsigned
> > char * should never warn, surely?
>=20
> I requested the use of __DECONST there. Nobody knows what would be next
> trend in the C language breaking among compiler writers. We guarantee
> that __DECONST() is adopted to whatever warnings are added.

We're not going to add an obfuscated cast through uintptr_t for every
change of signedness.  That would be absurd and there is no reason to
belive a future C would ever require it.

-- Brooks

--/04w6evG8XlLl3ft
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJjB+q6AAoJEKzQXbSebgfAlecIAJAUArVezHf+wshkh7moiyDY
5zpJlQd0sSZOgPNMJsh/ERgDd+g4n5aZd+POkn2RZlqGFfGdS039oYeHWYgv6RNJ
2EwQRuxcptRyUdNrqtoagEgOSAAXDsiGB2/wy88ScrA36YhoAeWLksRxfq7D6JUx
2Cvz+jqur88Uzdn5D8ygV7TjnbGMTAzKDxlEjRbEGYLCFmZz+KEElBqqxeBoeX8u
fPUCldlmbdX4ET4++bJyesrGyN8UJTYOPVWXG1HGEQgob4JSwvfOmIfKCaR9c5Vt
36SBiu34MlWwcmyCXqiHO4IioczRsIMFYpcrrP5/KFvjf2Laeaq+SHQSbZZtVBE=
=pfp1
-----END PGP SIGNATURE-----

--/04w6evG8XlLl3ft--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220825213347.GA89898>