From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 27 20:10:04 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D42D61065672
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 27 Feb 2008 20:10:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D2C6D8FC23
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 27 Feb 2008 20:10:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1RKA428048536
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 27 Feb 2008 20:10:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1RKA4lO048535;
	Wed, 27 Feb 2008 20:10:04 GMT (envelope-from gnats)
Date: Wed, 27 Feb 2008 20:10:04 GMT
Message-Id: <200802272010.m1RKA4lO048535@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Denis Barov <dindin@yandex-team.ru>
Cc: 
Subject: Re: kern/113398: [libc] initgroups fails rather than truncates if
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Denis Barov <dindin@yandex-team.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2008 20:10:05 -0000

The following reply was made to PR kern/113398; it has been noted by GNATS.

From: Denis Barov <dindin@yandex-team.ru>
To: bug-followup@FreeBSD.org, dean.povey@quest.com
Cc:  
Subject: Re: kern/113398: [libc] initgroups fails rather than truncates if
Date: Wed, 27 Feb 2008 23:06:54 +0300

 number of groups > NGROUPS_MAX meaning the user can no longer login
 Message-ID: <20080227170342.GE1139@sepulca.yandex.ru>
 MIME-Version: 1.0
 Content-Type: text/plain; charset=koi8-r
 Content-Disposition: inline
 X-Operating-System: FreeBSD sepulca.yandex.ru 6.3-STABLE FreeBSD 6.3-STABLE
 User-Agent: mutt-ng/devel-r804 (FreeBSD)
 Status: RO
 
 I'm sorry, previous patch just  increases number of groups to 64, and this
 one fixes problem.
 
 -- 
 Cheers
 Denis Barov
 
 diff -urN src/lib/libc/gen/initgroups.c.orig src/lib/libc/gen/initgroups.c
 --- src/lib/libc/gen/initgroups.c.orig  2003-11-19 18:51:26.000000000 +0300
 +++ src/lib/libc/gen/initgroups.c   2008-02-27 22:59:13.000000000 +0300
 @@ -42,6 +42,7 @@
  #include <stdio.h>
  #include "namespace.h"
  #include <err.h>
 +#include <errno.h>
  #include "un-namespace.h"
  #include <unistd.h>
 
 @@ -51,6 +52,7 @@
     gid_t agroup;
  {
     int ngroups;
 +    int result;
     /*
      * Provide space for one group more than NGROUPS to allow
      * setgroups to fail and set errno.
 @@ -59,5 +61,10 @@
 
     ngroups = NGROUPS + 1;
     getgrouplist(uname, agroup, groups, &ngroups);
 -   return (setgroups(ngroups, groups));
 +
 +    do
 +      result = setgroups (ngroups, groups);
 +    while (result == -1 && errno == EINVAL && --ngroups > 0);
 +
 +   return result;
  }