From owner-svn-src-head@freebsd.org Fri Aug 7 16:57:34 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5C0D3BF235; Fri, 7 Aug 2020 16:57:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNWkQ5FNvz4gCL; Fri, 7 Aug 2020 16:57:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 92A5215C13; Fri, 7 Aug 2020 16:57:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f178.google.com with SMTP id 77so2329746qkm.5; Fri, 07 Aug 2020 09:57:34 -0700 (PDT) X-Gm-Message-State: AOAM53001AWpHa/K0HODnDJbxA8pYJlQGVUPHphun4lZv880aQh55Jd5 bcipJKKnER0Cv53gJ6o0LoNLV4zVdBZccGpyFUY= X-Google-Smtp-Source: ABdhPJzpOB2iIK/I1gkRNbrdFKwM24Cs+rLeKeuEU61bFrRXqN1dtANn6a0JxoSQ7BAi6q4J49kkcAIDi6VuV2Wrshs= X-Received: by 2002:a37:d83:: with SMTP id 125mr14929838qkn.430.1596819454129; Fri, 07 Aug 2020 09:57:34 -0700 (PDT) MIME-Version: 1.0 References: <202008071604.077G41dj025962@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Fri, 7 Aug 2020 11:57:21 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r364023 - head/usr.bin/grep To: Alexander Richardson Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 16:57:34 -0000 On Fri, Aug 7, 2020 at 11:22 AM Alexander Richardson wrote: > > On Fri, 7 Aug 2020 at 17:06, Kyle Evans wrote: > > > > On Fri, Aug 7, 2020 at 11:04 AM Alex Richardson wrote: > > > > > > Author: arichardson > > > Date: Fri Aug 7 16:04:01 2020 > > > New Revision: 364023 > > > URL: https://svnweb.freebsd.org/changeset/base/364023 > > > > > > Log: > > > Always install usr.bin/grep as grep when bootstrapping > > > > > > We have to bootstrap grep when cross-building from macOS/Linux. > > > > > > > What's going on here that it isn't bootstrapping gnugrep over in > > gnu/usr.bin/grep as grep? My gut instinct is that we're missing > > something else and this isn't quite the right place to have addressed > > this. > > > > The logic in Makefile.inc1 builds usr.bin/grep as the bootstrap grep > when BOOTSTRAP_ALL_TOOLS is set (e.g. when building on macOS/Linux). > If you think this should be gnu/usr.bin/grep instead I can revert this > change and update Makefile.inc1. > We have been using usr.bin/grep for bootstrap in CheriBSD for a long > time now and it works fine so I'm not sure whether we need to use GNU > grep for bootstrapping? > I suspect that the correct path should've forced WITH_BSD_GREP at the top-level if it's going to explicitly use usr.bin/grep, but now that I think about it- let's not put any more thought into this... Ultimately, I'm going to be reverting this in due time as I flip the WITH_BSD_GREP switch to default and ultimately remove the whole conditional altogether not too long after that. This will remove the need completely. Thanks, Kyle Evans