Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Nov 2023 15:12:08 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 275039] dns/void-zones-tools: not WITH_PIE safe
Message-ID:  <bug-275039-7788-165weMDmZp@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-275039-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-275039-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275039

--- Comment #4 from Vidar Karlsen <vidar@karlsen.tech> ---
(In reply to Robert Clausecker from comment #3)

> This patch doesn't look right as it now unconditionally adds -fpic, even =
if we create a position-dependent binary.

That is a very good point.

> I don't get why you had -fno-pic in there in the first place.  If you jus=
t remove that flag, I suspect it'll just work as expected.

I don't know either. It's coming from upstream, and I don't know enough abo=
ut
compilers and their flags to put forth any meaningful argument about it.

Removing -fno-pic almost works, but the upstream Makefile does:
CFLAGS =3D $(CDEFS)
overwriting anything coming from the ports framework.
Changing that to +=3D does seem to do the trick.
I'll upload a new patch.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-275039-7788-165weMDmZp>