Date: Thu, 26 Aug 2004 10:09:40 -0700 From: Nate Lawson <nate@root.org> To: arch@freebsd.org Subject: Leave acpi enabled in panic shutdown case? Message-ID: <412E1954.5030908@root.org>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------000200030206080107010709 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit It seems some people may get a 2nd panic when acpi is shutdown after a panic. I think it makes sense not to do the normal shutdown path if panicing. Is the correct way to check for this panicstr != NULL? The attached patch avoids calling AcpiTerminate() for the panic case. -Nate --------------000200030206080107010709 Content-Type: text/plain; name="panic.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="panic.diff" Index: acpi.c =================================================================== RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v retrieving revision 1.189 diff -u -r1.189 acpi.c --- acpi.c 23 Aug 2004 16:28:42 -0000 1.189 +++ acpi.c 26 Aug 2004 01:37:13 -0000 @@ -1365,7 +1365,7 @@ DELAY(1000000); printf("ACPI power-off failed - timeout\n"); } - } else { + } else if (panicstr == NULL) { printf("Shutting down ACPI\n"); AcpiTerminate(); } --------------000200030206080107010709--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?412E1954.5030908>