From owner-svn-ports-all@freebsd.org Wed Nov 4 02:35:04 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0845EA25FC2; Wed, 4 Nov 2015 02:35:04 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) by mx1.freebsd.org (Postfix) with ESMTP id 9E5EE1AE2; Wed, 4 Nov 2015 02:35:03 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id tnsAZ7BZmT2votnsBZR91n; Tue, 03 Nov 2015 19:32:27 -0700 X-Authority-Analysis: v=2.1 cv=NrEbCZpJ c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=BWvPGDcYAAAA:8 a=VxmjJ2MpAAAA:8 a=kj9zAlcOel0A:10 a=qtqOOiqGOCEA:10 a=Wi8YH2NmAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=E00QO6NSS5neU4_zzLQA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTP id ED1289CD4; Tue, 3 Nov 2015 18:32:25 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id tA42WPl3079483; Tue, 3 Nov 2015 18:32:25 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201511040232.tA42WPl3079483@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Hiroki Sato cc: Cy.Schubert@komquats.com, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r400565 - head/security/pam_krb5 In-Reply-To: Message from Hiroki Sato of "Wed, 04 Nov 2015 08:36:41 +0900." <20151104.083641.2117830857202894349.hrs@allbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Nov 2015 18:32:25 -0800 X-CMAE-Envelope: MS4wfHpIgI2rIekwk/bV65g84VZlHnCCc20d718n374fhLL2uD7gnNpXHLIZgB5uTtOCUYgcti3pxs0GJkqzvzZTDvtnhX28JDv4IurSjQHFY+Yu/T+eEvWj5Upg2K+lz4OfbB7ssXlycqTtS33olZFNNjFCqBTeIgRO7T+eaMtiW92qdveAKYpDEjrPK0QT+zdEj7XcbucnaTzh2D7Uol5wyZ/j1mOWNsmKO38qTkfwXyj7bVTG3sfxvqveUqQ8IWJDN55yZjrKrfcvbKCX2b4yuyadahuvUSu+ZebcU0ggUQDMp0kHj+m1PvQJTgGNcIvcnA== X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 02:35:04 -0000 In message <20151104.083641.2117830857202894349.hrs@allbsd.org>, Hiroki Sato wr ites: > Cy Schubert wrote > in <201511030457.tA34vkf5040066@slippy.cwsent.com>: > > Cy> In message <56377C39.5000401@marino.st>, John Marino writes: > Cy> > We don't have to settle for what it is. We can control the build flags > . > Cy> > > Cy> > The bottom line is that a regression happened. If the current makefile > Cy> > can't be fixed to operate as it was before, the change should be > Cy> > reverted, right? > Cy> > Cy> Actually, it never worked in the first place. That is because the heimdal > Cy> port puts its include files in ${LOCALBASE}/include/heimdal (take note of > Cy> "heimdal" at the end of the path) and libraries in ${LOCALBASE}/lib/heimd > al > Cy> (same as above). Ldd ${LOCALBASE}/lib/security/pam_krb5.so makes that > Cy> abundantly clear. > Cy> > Cy> Having said that, it's still no reason or excuse for it not to work. Test > ed > Cy> in a virgin jail, it's working now, and committed. Sorry about the > Cy> confusion. > > Can you please use the pre-defined variables for them instead of > hardcoded pathnames? Pathnames for headers and libraries are defined > as GSSAPIINCDIR and GSSAPILIBDIR in gssapi.mk in an > implementation-neutral way (and "flags" modifier like > "gssapi:heimdal,flags" imports them into CFLAGS and LDFLAGS if > necessary). Tests for KRB5_HOME and HEIMDAL_HOME should also be > replaced with GSSAPIBASEDIR. I confirmed that the attached patch > worked fine. Thanks for the patch. It's a lot neater. Committed. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.