From owner-cvs-all@FreeBSD.ORG Wed Sep 22 20:03:36 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 247D416A4CE; Wed, 22 Sep 2004 20:03:36 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id C95A443D46; Wed, 22 Sep 2004 20:03:35 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net [67.127.84.57]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i8MK3YDl006572; Wed, 22 Sep 2004 13:03:34 -0700 Message-ID: <4151DA7E.7070804@root.org> Date: Wed, 22 Sep 2004 13:03:10 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <20040921230445.B44288@root.org> <20040922.085115.34541167.imp@bsdimp.com> <4151C1A7.2040905@root.org> <20040922.130051.119859553.imp@bsdimp.com> In-Reply-To: <20040922.130051.119859553.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb usb_port.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2004 20:03:36 -0000 M. Warner Losh wrote: > In message: <4151C1A7.2040905@root.org> > Nate Lawson writes: > : > : > free(device_get_ivars(dev), M_USB); \ > : > : > + device_detach(dev); \ > > Doh! OK. I get it now. We're lucky that the detach routine doesn't > access the ivars at all (they are only accessed in probe/attach) which > is what saves us... > > Warner Exactly what I meant. Thanks. -- Nate