Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Apr 2021 00:26:23 +0200
From:      Torsten Zuehlsdorff <freebsd@toco-domains.de>
To:        Matthias Andree <matthias.andree@tu-dortmund.de>, Mathieu Arnold <mat@freebsd.org>, Gerald Pfeifer <gerald@pfeifer.com>
Cc:        Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: a4c3b6f622b8 - main - Remove two tools that are no longer useful with Git.
Message-ID:  <9bf24e4c-6543-eda5-1e3d-3cf8bdf95dc3@toco-domains.de>
In-Reply-To: <0c47579d-9221-4bb4-4298-fac4cff3c543@tu-dortmund.de>
References:  <202104061040.136Ae3MR086471@gitrepo.freebsd.org> <8cde99cd-c64a-a85e-68dd-94bcf1d6999b@pfeifer.com> <20210412120941.ro5rv7vaokglgt7l@aching.in.mat.cc> <0c47579d-9221-4bb4-4298-fac4cff3c543@tu-dortmund.de>

next in thread | previous in thread | raw e-mail | index | archive | help


On 12.04.21 23:55, Matthias Andree wrote:
> Am 12.04.21 um 14:09 schrieb Mathieu Arnold:
>> On Sat, Apr 10, 2021 at 10:57:20PM +0200, Gerald Pfeifer wrote:
>>> On Tue, 6 Apr 2021, Rene Ladan wrote:
>>>>      Remove two tools that are no longer useful with Git.
>>>>      
>>>>      - mfh: this is replaced by 'git cherry-pick -x HASH'
>>>
>>> I believe it would be useful to still have such a tool that one simply
>>> invokes as "mfh $COMMITID" for the quarterly branch as in the past.
>>>
>>> https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-commit-mfh
>>> has instructions on how to do this manually, alas that is quite not
>>> as convenient - and hence likely to be used - as the nice original
>>> mfh tool.
>>
>> Well, with Git, mfh would end up being:
>>
>> git checkout 2021Q2
>> git cherry-pick -x $COMMITID
>> git push origin 2021Q2
>>
>> I would rather committers learn how to use git (it is, after all, what
>> they are here for) and then, they can magically now test before pushing.
>>
> 
> This is a fundamental misunderstanding of the purpose.
> Committers/developers are not here to learn Git,
> but they are here to develop.  Git is a tool, not an end in itself.
> 
> I also ask to revive the tool.  If it's so simple then there is no need
> to kill it.

Also beside saving some time you can add some benefits. Like adding a 
check if you are actually pushing into the correct quarterly branch. 
Lets bring back some of the easy checks!

Best,
Torsten



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9bf24e4c-6543-eda5-1e3d-3cf8bdf95dc3>