Date: Wed, 10 Apr 2019 18:58:11 +0000 (UTC) From: Randall Stewart <rrs@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r346094 - head/sys/netinet Message-ID: <201904101858.x3AIwB9T097263@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rrs Date: Wed Apr 10 18:58:11 2019 New Revision: 346094 URL: https://svnweb.freebsd.org/changeset/base/346094 Log: Fix a small bug in the tcp_log_id where the bucket was unlocked and yet the bucket-unlock flag was not changed to false. This can cause a panic if INVARIANTS is on and we go through the right path (though rare). This fixes the correct bug :) Reported by: syzbot+179a1ad49f3c4c215fa2@syzkaller.appspotmail.com Reviewed by: tuexen@ Modified: head/sys/netinet/tcp_log_buf.c Modified: head/sys/netinet/tcp_log_buf.c ============================================================================== --- head/sys/netinet/tcp_log_buf.c Wed Apr 10 18:17:27 2019 (r346093) +++ head/sys/netinet/tcp_log_buf.c Wed Apr 10 18:58:11 2019 (r346094) @@ -752,6 +752,7 @@ refind: RECHECK_INP(); if (tp->t_lib != NULL) { TCPID_BUCKET_UNLOCK(tlb); + bucket_locked = false; tlb = NULL; goto restart; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904101858.x3AIwB9T097263>