Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 Dec 2015 16:36:04 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 205142] www/photo_gallery: whitespace fix, modernize
Message-ID:  <bug-205142-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205142

            Bug ID: 205142
           Summary: www/photo_gallery: whitespace fix, modernize
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: amdmi3@FreeBSD.org
                CC: bob@bomar.us
             Flags: maintainer-feedback?(bob@bomar.us)
                CC: bob@bomar.us

Created attachment 163993
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163993&action=edit
Patch

- Fix extra whitespace
- Switch to COPYTREE_SHARE
- Add NO_ARCH
- Don't set owner/group: this does open any files for writing, so it doesn't
need any write permissions
- Drop @dirrm

For convenience, here's the same diff but with whitespace changes ignored:

---
Index: Makefile
===================================================================
--- Makefile    (revision 403272)
+++ Makefile    (working copy)
@@ -20,10 +20,10 @@
 SHEBANG_FILES= index.cgi
 perl_OLD_CMD=  /usr/pkg/bin/perl
 NO_BUILD=      yes
+NO_ARCH=       yes

 do-install:
                ${MKDIR} ${STAGEDIR}${WWWDIR}/
-               @cd ${WRKSRC}; ${FIND} . \
-                       | ${CPIO} -pdm -R ${WWWOWN}:${WWWGRP}
${STAGEDIR}${WWWDIR}
+       @cd ${WRKSRC}; ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}

 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
--- pkg-plist   (revision 403272)
+++ pkg-plist   (working copy)
@@ -2,4 +2,3 @@
 %%WWWDIR%%/readme.html
 %%WWWDIR%%/.header.html
 %%WWWDIR%%/.footer.html
-@dirrm %%WWWDIR%%
---

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205142-13>