From owner-svn-src-head@freebsd.org Wed Aug 17 15:57:45 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4512BBD286 for ; Wed, 17 Aug 2016 15:57:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B6551B48 for ; Wed, 17 Aug 2016 15:57:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x230.google.com with SMTP id f6so95270825ith.0 for ; Wed, 17 Aug 2016 08:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OWdDeo5p8TbGZXEy2BHOYjfW5WQFv/tv5+s847PJkv0=; b=bLfvT3X40eHSZ4tK4Fq0j0zrEUPsBu4gDdNxAehVVrrU0ns3G5dLkHNaYZ85bPYPMZ 3tllWb52S6PKgVliaCJEO6to+Aw37ZivIqtrFqoOgT3wL0yjVcG9QazWvDZS1gpZRPgP Z5DQIXhU9QQz85TWuWCTjlcJILFAqvqAdvi5GULFJOfvXMXQ9MPCwnmwyl5r8mLgshRB vObkcHB0jsDPL/Bu5pexA1o1LI282wWq+qWJnHykJKO09yG08S7Z8t4T7LaDnTWAsvTD PW9G5ibJtzh42mqopAAvfTXaKOkV1QFX6xOt3Y8dfw40gCW6q7cv/K0/52Bh5umhhBbh N2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OWdDeo5p8TbGZXEy2BHOYjfW5WQFv/tv5+s847PJkv0=; b=H0ZyF24jKgY4rtlaeHLzIeZJ6OXHNTLtXpV9U+IAT9lUx8Mld/i1DYnZpv8YiRgXyK dtMjfm9RQfPswMtH9pPfXJR0lb86nVazUDiQMNnRIsj+SreqKTeYqn1/AcM1VoRagZca 2iQVkflYfzLx6qMFmRrRdhd4c9/MyAZEJn2jq7KEPvBE8a+1aPjOFrLew0EpfoyCvl74 Ll86NrpfTuOxGol3FwIKKuXTf6HRGmch37BQHv02vpJu2SvpLNCcelyEabJfLxsq1ID7 OVSUL46s7TOfx3ws+ZAgTIh+zJZks1Y74sIHmwF3WgJF20QDitHkgbKX/K/KdhQbHwUj DIww== X-Gm-Message-State: AEkoouvh31/SDrVMimGJO5mUpv4DoEyZQJsxkH7iF8/EWW1oFJo/Ei0qByGuL82g0sRzGlc1DF3yD/ufG4BcLg== X-Received: by 10.36.213.131 with SMTP id a125mr28507079itg.14.1471449464862; Wed, 17 Aug 2016 08:57:44 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Wed, 17 Aug 2016 08:57:44 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <8cb3fa1a-50cb-e238-d006-b98a628d446d@freebsd.org> References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> <86wpjf4eun.fsf@desk.des.no> <8cb3fa1a-50cb-e238-d006-b98a628d446d@freebsd.org> From: Warner Losh Date: Wed, 17 Aug 2016 09:57:44 -0600 X-Google-Sender-Auth: 0hCCn9pT0_4YusyeE7b6_TZ72PA Message-ID: Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit To: Nathan Whitehorn Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 15:57:45 -0000 On Wed, Aug 17, 2016 at 9:26 AM, Nathan Whitehorn wrote: > Not true at all. All modern disks report their physical sector size, as > distinct from the logical one, in their ATA IDENTIFY data and ata_da.c uses > that. You are correct that there are two fields in the ATA IDENTIFY. However, you are incorrect in thinking that all modern disks report their actual physical sector size instead of a 'compatibility' number. We have dozens of quirks and are adding them at the rate of a couple a month to make the current imperfect magic happen. > There is also a small quirks table for some older spinning disks and a > few SSDs that lie and mostly hasn't needed additions in quite some time. > camcontrol identify correctly reports 4096 for the physical sector size on 5 > different random AF-512e disks I just checked (some of those are also, > redundantly, in the quirks table). Since this seems to have become the > standard, I can't imagine that the quirks table would need to grow much in > the future for this issue. Any yet the table continues to grow. As someone who evaluates disks for a large streaming media company, you cannot begin to imagine the number of things that vendors get wrong... Life would be so much easier if you could actually trust vendors to report things correctly in their ATA IDENTIFY command. SCSI is better, but still not perfect. You should really listen to people that have been on the front line here. CAM does a decent job of getting things right. It isn't perfect and can never be perfect. Expecting it to magically change to be perfect is unreasonable and will literally never happen. Warner