From nobody Fri Aug 26 16:21:01 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MDlSY5bphz4ZQHn; Fri, 26 Aug 2022 16:21:01 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MDlSY58krz3Hy9; Fri, 26 Aug 2022 16:21:01 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661530861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DB1d/MjRIoY1UJR/vAEjTL/roSgfEz1E/z1XeIB9XPE=; b=M96a85+3ICXrwDyP51hdBjIrrarQVRM9cLzRm4bCoKrEkO2RUia+vHY/H8LDLLT8ivqaC8 hFlDf9etMJBeZvU1JW1+Xdw4eH5QwvQ0yWxEtTYBOm5qwZmvZ5qNCNIshp66IizgK4UVSL qJXe19BFvPvMMcVfq/y17Jvzooe7YpZnPrTBvKcj4B3SX2VuTer9vMtc52adIq7hKizSYS CAbm0xVjUCISQugRooDKTAD5qwyNuS/nLbqel8dP71m2IxU36dKkauI/9sFYcFw5HY5//f u1ovDUXIy7aPXS3PSzi9fx44n7fOwNc3u26HAzrM4UoXEUMye8K0MzdzdddPKw== Received: from [192.168.1.8] (host-95-234-99-58.retail.telecomitalia.it [95.234.99.58]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: asiciliano) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MDlSX6cpqz13Zq; Fri, 26 Aug 2022 16:21:00 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) Message-ID: Date: Fri, 26 Aug 2022 18:21:01 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog Content-Language: en-US To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> <4663E594-C2B2-4496-9BAF-1AD2F6707D50@freebsd.org> From: "Alfonso S. Siciliano" In-Reply-To: <4663E594-C2B2-4496-9BAF-1AD2F6707D50@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661530861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DB1d/MjRIoY1UJR/vAEjTL/roSgfEz1E/z1XeIB9XPE=; b=CHFlq11iIyBtejH5hC5J0con3ejZ7lq4icYjbnP4SXFdsXodNoz0mezywElJPjEFRF1nZW IMF0mneuvzUy+/HKP8uLaCfda9TcmCMrCUamJziIyEiofah8R5DA6FpZKnUWl0sqqA4eHJ 6L29FcTafTfGpgBDLT/9xz41yQA8qn6BqVUyn9rxrwmFulCXqxak8ekoNyAa382Fi8oWo9 AirFNo97zgD/8vqmlHnTCzRJFgn2mQQUCv6K1rl7c6q8nKUABAOkhL47BLusWgFaYj4eGD BepISPJ8PY/OBU1M2/R6QAGKfRfsL9l0DGGHFxgwWlm9Z48d40cjgydd2UjJkQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661530861; a=rsa-sha256; cv=none; b=PNjZmK4ekT1arsvzneGEPYXJhSkOEV2JOmjOjT1kIfb6amv1c06WXlfKLOnc8xODkM64CK jDNjhdKBKItBBaxoDLEKAYKNVxfz9SgGtGiPpxCJCYoI2Ss2WpvsLroF0p8/OlGllVExQB MntCmKcwwxpP6RLxJAdc7nByrczdEckrcNQdnvqnMUcVWQlih/lQtSV9Mo6oIx8UK1agIc 6OvmbRJ3pPjCt9DGHrVpm3B+Y0Qn/gCmKWmQhaVnkUng4UlYZMy0SbI4oCy7mCnCPT3sld VLAPjzKkVfbWhdsWZ/raDxJNvqfsuvLl6Idx0MT9xpFKon+brWuEbkqc+nowoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 7/14/22 02:06, Jessica Clarke wrote: > On 23 Mar 2022, at 15:57, Alfonso S. Siciliano wrote: >> >> The branch main has been updated by asiciliano: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8 >> >> commit 0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8 >> Author: Alfonso S. Siciliano >> AuthorDate: 2022-03-23 15:52:39 +0000 >> Commit: Alfonso S. Siciliano >> CommitDate: 2022-03-23 15:56:37 +0000 >> >> bsdinstall time: Replace dialog with bsddialog >> >> Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility, >> 'dialog --calendar' is replaced by 'bsddialog --datebox' with same >> features but different User Interface. >> >> Approved by: bapt (mentor) >> Differential Revision: https://reviews.freebsd.org/D34583 >> --- >> usr.sbin/bsdinstall/scripts/time | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/usr.sbin/bsdinstall/scripts/time b/usr.sbin/bsdinstall/scripts/time >> index cccd5999a035..5db4b48f7531 100755 >> --- a/usr.sbin/bsdinstall/scripts/time >> +++ b/usr.sbin/bsdinstall/scripts/time >> @@ -36,23 +36,23 @@ export TZ >> >> # Set date >> exec 3>&1 >> -DATE=$(dialog --backtitle 'FreeBSD Installer' \ >> - --title 'Time & Date' \ >> +DATE=$(bsddialog --backtitle 'FreeBSD Installer' \ >> + --title ' Date ' \ >> --ok-label 'Set Date' \ >> --cancel-label 'Skip' \ >> - --defaultno \ >> + --default-no \ >> --date-format '%Y%m%d%H%M.%S' \ >> - --calendar '' 0 40 \ >> + --datebox '' 0 40 \ >> 2>&1 1>&3) && date $DATE >> exec 3>&- >> >> # Set time >> exec 3>&1 >> -TIME=$(dialog --backtitle 'FreeBSD Installer' \ >> - --title 'Time & Date' \ >> +TIME=$(bsddialog --backtitle 'FreeBSD Installer' \ >> + --title ' Time ' \ >> --ok-label 'Set Time' \ >> --cancel-label 'Skip' \ >> - --defaultno \ >> + --default-no \ >> --time-format '%H%M.%S' \ >> --timebox '' 0 40 \ >> 2>&1 1>&3) && date $TIME > Sorry for the late answer. Unfortunately, today I found out that gmail hid some emails from @freebsd.org ("...Gmail could not verify that it actually came from freebsd.org. ... "), fixed adding a filter. > Something I missed until trying out an image post this commit: > bsddialog’s --timebox implementation does not zero-pad the numbers, so > you end up with nonsense like 1:2:3 rather than 01:02:03 (or 1:02:03, > but 01:02:03 generally looks better). Usually I update and fix similar stuff immediately. However a new version (with this change) is almost ready to be imported. Just a while to test. > > Having the date displayed as YYYY/monthname/DD for --datebox is also a > bit strange, but I can see reasons for doing that I guess. > > Jess > I have not a strong opinion about date format. The situation seems quite confused: If you or others have any preferences I' ll update. Alfonso