Date: Fri, 26 Aug 2022 18:21:01 +0200 From: "Alfonso S. Siciliano" <asiciliano@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog Message-ID: <e49a7ea2-918d-3842-6a1c-59d8285b3ce9@FreeBSD.org> In-Reply-To: <4663E594-C2B2-4496-9BAF-1AD2F6707D50@freebsd.org> References: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> <4663E594-C2B2-4496-9BAF-1AD2F6707D50@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/14/22 02:06, Jessica Clarke wrote: > On 23 Mar 2022, at 15:57, Alfonso S. Siciliano <asiciliano@FreeBSD.org> wrote: >> >> The branch main has been updated by asiciliano: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8 >> >> commit 0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8 >> Author: Alfonso S. Siciliano <asiciliano@FreeBSD.org> >> AuthorDate: 2022-03-23 15:52:39 +0000 >> Commit: Alfonso S. Siciliano <asiciliano@FreeBSD.org> >> CommitDate: 2022-03-23 15:56:37 +0000 >> >> bsdinstall time: Replace dialog with bsddialog >> >> Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility, >> 'dialog --calendar' is replaced by 'bsddialog --datebox' with same >> features but different User Interface. >> >> Approved by: bapt (mentor) >> Differential Revision: https://reviews.freebsd.org/D34583 >> --- >> usr.sbin/bsdinstall/scripts/time | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/usr.sbin/bsdinstall/scripts/time b/usr.sbin/bsdinstall/scripts/time >> index cccd5999a035..5db4b48f7531 100755 >> --- a/usr.sbin/bsdinstall/scripts/time >> +++ b/usr.sbin/bsdinstall/scripts/time >> @@ -36,23 +36,23 @@ export TZ >> >> # Set date >> exec 3>&1 >> -DATE=$(dialog --backtitle 'FreeBSD Installer' \ >> - --title 'Time & Date' \ >> +DATE=$(bsddialog --backtitle 'FreeBSD Installer' \ >> + --title ' Date ' \ >> --ok-label 'Set Date' \ >> --cancel-label 'Skip' \ >> - --defaultno \ >> + --default-no \ >> --date-format '%Y%m%d%H%M.%S' \ >> - --calendar '' 0 40 \ >> + --datebox '' 0 40 \ >> 2>&1 1>&3) && date $DATE >> exec 3>&- >> >> # Set time >> exec 3>&1 >> -TIME=$(dialog --backtitle 'FreeBSD Installer' \ >> - --title 'Time & Date' \ >> +TIME=$(bsddialog --backtitle 'FreeBSD Installer' \ >> + --title ' Time ' \ >> --ok-label 'Set Time' \ >> --cancel-label 'Skip' \ >> - --defaultno \ >> + --default-no \ >> --time-format '%H%M.%S' \ >> --timebox '' 0 40 \ >> 2>&1 1>&3) && date $TIME > Sorry for the late answer. Unfortunately, today I found out that gmail hid some emails from @freebsd.org ("...Gmail could not verify that it actually came from freebsd.org. ... "), fixed adding a filter. > Something I missed until trying out an image post this commit: > bsddialog’s --timebox implementation does not zero-pad the numbers, so > you end up with nonsense like 1:2:3 rather than 01:02:03 (or 1:02:03, > but 01:02:03 generally looks better). Usually I update and fix similar stuff immediately. However a new version (with this change) is almost ready to be imported. Just a while to test. > > Having the date displayed as YYYY/monthname/DD for --datebox is also a > bit strange, but I can see reasons for doing that I guess. > > Jess > I have not a strong opinion about date format. The situation seems quite confused: <https://iso.mit.edu/americanisms/date-format-in-the-united-states/>; <https://en.wikipedia.org/wiki/Date_and_time_notation_in_the_United_States>; If you or others have any preferences I' ll update. Alfonso
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e49a7ea2-918d-3842-6a1c-59d8285b3ce9>