From owner-svn-src-all@freebsd.org Wed Mar 23 02:46:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AFBFAC981A; Wed, 23 Mar 2016 02:46:28 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 324D81D67; Wed, 23 Mar 2016 02:46:28 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-ob0-x232.google.com with SMTP id fp4so1828611obb.2; Tue, 22 Mar 2016 19:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=hxfpoXkFn8iKwxdp6I3zjcci8SardQXTsbRAHUrW2FM=; b=yT1ctm3A2iKnWebQz79KWVKdbSapy1avNM93Y31PD8u6yd6j5fJhXP3TNscUVez0St FecAtKZyRv8io8KgNJ/GJ7OJ7SKiBGhxQkTziRgs3z1OakpYsVs0k2rN4CSC+vGPOlmn yC3v0gI7+Rp5ylGvDvpPYDXI7Tkz4pN5XP/J0cbrnmqY53Y+urK7Gp0Qf8SOzQUpetOj 5O3o7VmLpDyCigM4kwRndcsdwZoXvyhDUKd67APIvF/q0mBdZLRREpnTmgn4yk98z7Ix QhDGCUOaElvaKX6+Hjh/SZ6mrSj21CCgt42Oe8/zRdWi0pQX93qdEaLPnMVu5D4Bc7hK qoyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=hxfpoXkFn8iKwxdp6I3zjcci8SardQXTsbRAHUrW2FM=; b=JRG/HXQyB7UaI7AaBQbTClYcdEdh7w79XL5vdkr6/8uVzvAOH0dIL4NZpAFSPASioB X7edUm0bfj2cnCKWYPUHEN8q6g+9HB1P3Z21kjy+YRMN0/8FFhq2euhvzFTgnHmULBaY JulD1fOgSa9G9oUaH0QA3qZTpoSK8qDBYigQu7d5gkzDe5hiEud3DcKCBGDUqc/ZUysV CP9Etenwdr/LvM8FiBoOcFAOdgBWeTkaw4bjIUOnKwQNPU2Yn1sjQtj/q3oibP354daL pVCF38JLYgLh2nkB4GBVwuidL72EK6E30QrI/EYgpsYiPAL4Jq3Eae+2cEU7EYCzycHp YHeA== X-Gm-Message-State: AD7BkJJ8XmEScCXvAB7ly/6MVZ1O9G+Yln2J3H2vOzy+LaAGgrFODB/eWNV8t7THKDWb77hn+CPAIjJxoP+RFQ== MIME-Version: 1.0 X-Received: by 10.182.138.7 with SMTP id qm7mr211130obb.58.1458701187478; Tue, 22 Mar 2016 19:46:27 -0700 (PDT) Received: by 10.157.40.69 with HTTP; Tue, 22 Mar 2016 19:46:27 -0700 (PDT) In-Reply-To: References: <201603222241.u2MMf7ub090070@repo.freebsd.org> Date: Tue, 22 Mar 2016 21:46:27 -0500 Message-ID: Subject: Re: svn commit: r297201 - in head: share/man/man4 sys/dev/filemon From: Benjamin Kaduk To: Bryan Drewery Cc: "cem@FreeBSD.org" , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 02:46:28 -0000 On Tue, Mar 22, 2016 at 9:11 PM, Bryan Drewery wrote: > > > > The manpage for close(2) does document some errors, one being ENOSPC. The > close(2) behavior of returning write(2), really VOP_WRITE(9), errors though > is specific to filemon since all of the writes are hidden and this is the > only place to return an error. I have a review open to resolve a similar > issue in alq(9) as well since all of the writes are asynchronous and > there's no API to retrieve any error from. > filemon is not unique in this regard; the AFS filesystem buffers writes locally and in some cases errors writing to the remote server can be delayed until close(). Of course, very few softwares actually check the return value of close, so this can cause trouble sometimes... -Ben