From owner-cvs-all Thu Mar 7 3: 6:53 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 8459D37B41A; Thu, 7 Mar 2002 03:06:47 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g27B6mG63629; Thu, 7 Mar 2002 03:06:48 -0800 (PST) (envelope-from obrien) Date: Thu, 7 Mar 2002 03:02:44 -0800 From: "David O'Brien" To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307030244.B63484@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200203042027.g24KRc978637@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203042027.g24KRc978637@freefall.freebsd.org>; from markm@FreeBSD.org on Mon, Mar 04, 2002 at 12:27:38PM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 04, 2002 at 12:27:38PM -0800, Mark Murray wrote: > markm 2002/03/04 12:27:38 PST > > Modified files: > usr.bin/rwall rwall.c > Log: > ANSIfication, WARNS and lint cleanup. - (void)snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP); + snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP); lint(1) does not like our usage of (void)? Removing it where it already exists goes against the examples in style(9). - if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+"))) + fd = mkstemp(tmpname); + fp = fdopen(fd, "r+"); + if (fd == -1 || !fp) Why did you need to do such code restructuring? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message