From owner-cvs-all Sat Sep 16 16:17: 1 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id DA8C937B423; Sat, 16 Sep 2000 16:16:57 -0700 (PDT) Received: from localhost (kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) with ESMTP id QAA47552; Sat, 16 Sep 2000 16:16:57 -0700 (PDT) (envelope-from kris@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: kris owned process doing -bs Date: Sat, 16 Sep 2000 16:16:57 -0700 (PDT) From: Kris Kennaway To: Ade Lovett Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/games/xlines Makefile ports/games/xlines/patches patch-aa In-Reply-To: <20000916180157.P84360@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 16 Sep 2000, Ade Lovett wrote: > On Sat, Sep 16, 2000 at 03:06:45PM -0700, Kris Kennaway wrote: > > > Modified files: > > > games/xlines/patches patch-aa > > > > Does this need a PORTREVISION bump for the patch? > > Seeing as it's a modification of an existing patch, rather than > the addition of a new one, I don't think so. Unless I'm looking > in completely the wrong place, I don't see any mention at all > of exactly when PORTREVISION should be used. Portrevision is used when the end product changes in such a way that people may want to know about the newer version and update. So if you modify a patch such that it functionally affects the binary, you should bump it - whether or not the patch is new is immaterial. Kris -- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message