From owner-p4-projects@FreeBSD.ORG  Wed Dec  6 15:49:04 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 266CE16A47E; Wed,  6 Dec 2006 15:49:04 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F293F16A403;
	Wed,  6 Dec 2006 15:49:03 +0000 (UTC) (envelope-from zec@icir.org)
Received: from xaqua.tel.fer.hr (xaqua.tel.fer.hr [161.53.19.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9179F43CA7;
	Wed,  6 Dec 2006 15:48:17 +0000 (GMT) (envelope-from zec@icir.org)
Received: by xaqua.tel.fer.hr (Postfix, from userid 20006)
	id 653EC9B65B; Wed,  6 Dec 2006 16:49:02 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on xaqua.tel.fer.hr
X-Spam-Level: 
X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.7
Received: from [192.168.200.106] (zec2.tel.fer.hr [161.53.19.79])
	by xaqua.tel.fer.hr (Postfix) with ESMTP id 903349B656;
	Wed,  6 Dec 2006 16:49:01 +0100 (CET)
From: Marko Zec <zec@icir.org>
To: Andre Oppermann <andre@freebsd.org>
Date: Wed, 6 Dec 2006 16:48:58 +0100
User-Agent: KMail/1.9.1
References: <200612061531.kB6FVR67021263@repoman.freebsd.org>
	<4576E406.4010108@freebsd.org>
In-Reply-To: <4576E406.4010108@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200612061648.59255.zec@icir.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>, Marko Zec <zec@freebsd.org>
Subject: Re: PERFORCE change 111198 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2006 15:49:04 -0000

On Wednesday 06 December 2006 16:38, Andre Oppermann wrote:
> Marko Zec wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=111198
> >
> > Change 111198 by zec@zec_tpx32 on 2006/12/06 15:31:22
> >
> > 	Store a pointer back to the owner vnet in struct inpcbinfo,
> > 	so that whenever an inpcb is directly or indirectly available
> > 	as an argument to a function, the function-local vnet ptr can
> > 	be fetched from there, and not via the curvnetb macro.
>
> Ugh, this will become locking/refcounting hell.

Hmm, why?  This change doesn't introduce or need any additional refcounting.  
Each vnet has its own instance of inpcbinfo, hence inpcbinfo->vnet binding is 
permanent.  A vnet can't be removed until its inpcbinfo->ipi_count tells us 
there are no inpcbs pointing back to it any more.

Marko