Date: Tue, 05 Mar 2013 22:31:37 +0100 From: Olli Hauer <ohauer@FreeBSD.org> To: Chris Rees <crees@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r313372 - in head: devel/pecl-spread net/spread4 net/spread4/files Message-ID: <51366439.8040206@FreeBSD.org> In-Reply-To: <CADLo839kiLsUtC8-_Uwwu=BDcvvom8VhL2PHmposWGEOmeiQ5w@mail.gmail.com> References: <201303031812.r23IC6D3033581@svn.freebsd.org> <CADLo839kiLsUtC8-_Uwwu=BDcvvom8VhL2PHmposWGEOmeiQ5w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-03-05 20:01, Chris Rees wrote:
> On 3 March 2013 18:12, Olli Hauer <ohauer@freebsd.org> wrote:
>
> <snip>
>
>> +spread_cleanup() {
>> + [ -f ${pidfile} ] && rm -f ${pidfile}
>
>
> Isn't checking a file exists rather redundant if you're going to use
> rm -f on it?
>
> Chris
>
Good catch,
I prefer checking for existence before deleting a file from a script
(instead using rm -f $var blindly) and a normal rm is sufficient here.
However I would avoid changing it now because I don't want to bump
PORTREVISION for such a change.
--
Regards,
olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51366439.8040206>