From owner-freebsd-hackers@FreeBSD.ORG Mon Feb 20 20:09:11 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B27E2106564A for ; Mon, 20 Feb 2012 20:09:11 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 792938FC16 for ; Mon, 20 Feb 2012 20:09:11 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com (192.168.222.22) by WTL-EXCH-1.sandvine.com (192.168.196.31) with Microsoft SMTP Server id 14.1.339.1; Mon, 20 Feb 2012 15:09:10 -0500 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id 990B933C02; Mon, 20 Feb 2012 15:09:10 -0500 (EST) Date: Mon, 20 Feb 2012 15:09:10 -0500 From: Ed Maste To: Message-ID: <20120220200910.GA46212@sandvine.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Subject: tftpd: avoid logging error for pxeboot option negotiation? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2012 20:09:11 -0000 After upgrading a diskless boot server from FreeBSD 6 to 8 I see an error message logged each time a diskless client boots: Feb 20 00:56:38 TPC-D4-35 tftpd[55229]: Got ERROR packet: TFTP Aborted It turns out that the pxeboot client (from Intel) first performs a TFTP read request with the tsize option to which it receives an acknowledgement containing the size of the file to be transferred. Then it sends back an error response to abort the transfer, and sends the read request again (without the tsize option). The sequence of packets is: 1. C->S TFTP Read Request, File: pxeboot, Transfer type: octet, tsize=0 2. S->C TFTP Option Acknowledgement, tsize=239616 3. C->S TFTP Error Code, Code: Not defined, Message: TFTP Aborted 4. C->S TFTP Read Request, File: pxeboot, Transfer type: octet, blksize=1456 5. S->C TFTP Option Acknowledgement, blksize=1456 6. C->S TFTP Acknowledgement, Block: 0 7. S->C TFTP Data Packet, Block: 1 ... I'd like to avoid logging the error here, for the sake of this pxeboot client and any other tftp clients that might check options without actually starting a transfer. Anyone opposed to removing it? (A proposed patch is at http://people.freebsd.org/~emaste/tftpd.diff). -Ed