From owner-cvs-all@FreeBSD.ORG Tue Dec 12 23:27:10 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2675816A4D8; Tue, 12 Dec 2006 23:27:10 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD4D144553; Tue, 12 Dec 2006 23:08:07 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id kBCN9Mu8086899; Tue, 12 Dec 2006 18:09:22 -0500 (EST) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Oleg Bulyzhin Date: Tue, 12 Dec 2006 18:09:17 -0500 User-Agent: KMail/1.6.2 References: <200612010108.kB118qxY020349@repoman.freebsd.org> <20061212220557.GC91560@lath.rinet.ru> In-Reply-To: <20061212220557.GC91560@lath.rinet.ru> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200612121809.19564.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88.6/2319/Tue Dec 12 15:09:22 2006 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 23:27:10 -0000 On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: > On Fri, Dec 01, 2006 at 01:08:52AM +0000, Jung-uk Kim wrote: > > jkim 2006-12-01 01:08:52 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c if_bgereg.h > > Log: > > Simplify statistics updates, remove redundant register reads, > > and add discarded RX packets to input error for BCM5705 or newer > > chipset as the others. Unfortunately we cannot do the same for > > output errors because ifOutDiscards equivalent register does not > > exist. While I am here, replace misleading and wrong > > BGE_RX_STATS/BGE_TX_STATS with BGE_MAC_STATS. They were reversed > > but worked accidently. > > > > Revision Changes Path > > 1.153 +15 -23 src/sys/dev/bge/if_bge.c > > 1.58 +4 -5 src/sys/dev/bge/if_bgereg.h > > I would say you have simplified it too much. With your change you > will get wrong numbers after ifconfig down/up (since it implies > hardware counters reset while sc->bge_* counters are not cleared). I did clear sc->bge_* counter: @@ -3368,6 +3357,9 @@ bge_init_locked(struct bge_softc *sc) /* Init our RX return ring index. */ sc->bge_rx_saved_considx = 0; + + /* Init our RX/TX stat counters. */ + sc->bge_rx_discards = sc->bge_tx_discards = sc->bge_tx_collisions = 0; /* Init TX ring. */ bge_init_tx_ring(sc); While ifconfig down/up, bge_init_locked() should be called. Did I miss something? Jung-uk Kim