From owner-svn-src-head@FreeBSD.ORG  Fri Dec 26 11:53:47 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8BD2FA5B;
 Fri, 26 Dec 2014 11:53:47 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 6C3F864741;
 Fri, 26 Dec 2014 11:53:46 +0000 (UTC)
Received: from bender (unknown [213.205.252.212])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id 9C0087328F;
 Fri, 26 Dec 2014 11:53:45 +0000 (UTC)
Date: Fri, 26 Dec 2014 11:53:43 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Rui Paulo <rpaulo@me.com>
Subject: Re: svn commit: r276187 - head/sys/arm/arm
Message-ID: <20141226115343.7abbd2d4@bender>
In-Reply-To: <9F69A6CD-D352-4A91-97F6-B3E1FF638211@me.com>
References: <201412241712.sBOHCqvW039381@svn.freebsd.org>
 <20141224222637.03a19e57@bender>
 <1419460812.1018.157.camel@freebsd.org>
 <8E8B7FE3-0C97-4A84-BC1D-1C5A0E732D0C@me.com>
 <1419471084.1018.160.camel@freebsd.org>
 <9F69A6CD-D352-4A91-97F6-B3E1FF638211@me.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Ian Lepore <ian@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Dec 2014 11:53:47 -0000

On Wed, 24 Dec 2014 18:05:47 -0800
Rui Paulo <rpaulo@me.com> wrote:

> On Dec 24, 2014, at 17:31, Ian Lepore <ian@FreeBSD.org> wrote:
> > In every architecture and every place it's used, or just arm just
> > here?
> 
> You're right, it can be found at least in MIPS and amd64.
> 
> > This appears to be an idiom, or at least something that has been
> > pasted in identical form in every arch so far.
> 
> The idiom is a bit different in amd64: the variable in the for-loop
> isn't immediately reused, but it's a global variable anyway...
> That's what I thought deserves a comment.

I agree we should add a comment here. It's non-obvious the functions
will return the same value across multiple calls.
 
> Regarding the pmap_kenter_temporary(), the first problem is the
> function name: it might be a temporary mapping, but the real use is
> for crash dumps (I wonder why ACPI abuses this mapping).  The other
> problem is the fact that a pmap function is so tied to crash dumps.
> However, that's a bigger problem.

Yes, this functions looks like it needs to be reworked a little but I
would have to think about it first.

Andrew