From owner-p4-projects@FreeBSD.ORG Fri Jan 4 18:40:43 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EDAE016A419; Fri, 4 Jan 2008 18:40:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B08F316A417; Fri, 4 Jan 2008 18:40:42 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (cl-162.ewr-01.us.sixxs.net [IPv6:2001:4830:1200:a1::2]) by mx1.freebsd.org (Postfix) with ESMTP id 2D12A13C459; Fri, 4 Jan 2008 18:40:42 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m04IeatS045098; Fri, 4 Jan 2008 12:40:36 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.1/8.13.8/Submit) id m04IeakB045097; Fri, 4 Jan 2008 12:40:36 -0600 (CST) (envelope-from brooks) Date: Fri, 4 Jan 2008 12:40:36 -0600 From: Brooks Davis To: "M. Warner Losh" Message-ID: <20080104184036.GB44815@lor.one-eyed-alien.net> References: <200801041711.m04HBGPG029002@repoman.freebsd.org> <20080104.111926.-108774279.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline In-Reply-To: <20080104.111926.-108774279.imp@bsdimp.com> User-Agent: Mutt/1.5.16 (2007-06-09) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 04 Jan 2008 12:40:37 -0600 (CST) Cc: gonzo@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 132497 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 18:40:43 -0000 --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2008 at 11:19:26AM -0700, M. Warner Losh wrote: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org> > Oleksandr Tymoshenko writes: > : http://perforce.freebsd.org/chv.cgi?CH=3D132497 > :=20 > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07 > :=20 > : o I believe MK_ZFS is more appropriate variable to be checked > : in this case. >=20 > I thought this was more a case of 'exclude all CDDL code' rather than > being tied to ZFS. ${MK_CDDL} =3D=3D "no" absolutely needs to cause ZFS bits to not build. I'm not sure if ${MK_CDDL} =3D=3D "no" implies ${MK_ZFS} !=3D "no". If so this= is OK, if not it isn't. -- Brooks > Warner >=20 > : Affected files ... > :=20 > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit > :=20 > : Differences ... > :=20 > : =3D=3D=3D=3D //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (= text+ko) =3D=3D=3D=3D > :=20 > : @@ -13,7 +13,7 @@ > : =20 > : CFLAGS+=3D-D_KVM_VNODE > : =20 > : -.if ${MK_CDDL} !=3D "no" > : +.if ${MK_ZFS} !=3D "no" > : CFLAGS+=3D -DZFS > : OBJS+=3D zfs/zfs.o > : SUBDIR=3D zfs > :=20 >=20 --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHfn2kXY6L6fI4GtQRAppgAJ9QpvBkC8V539jW5pooqk8kHPSlKQCdEBj3 RUXMZedaJ5BDZF7ZEpzaK3k= =4i0l -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ--