From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 30 08:50:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11A41106566C for ; Tue, 30 Mar 2010 08:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C90978FC15 for ; Tue, 30 Mar 2010 08:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2U8o3rO014684 for ; Tue, 30 Mar 2010 08:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2U8o3nx014683; Tue, 30 Mar 2010 08:50:03 GMT (envelope-from gnats) Resent-Date: Tue, 30 Mar 2010 08:50:03 GMT Resent-Message-Id: <201003300850.o2U8o3nx014683@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Fedor Dikarev Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 975231065676 for ; Tue, 30 Mar 2010 08:42:27 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id E29788FC1E for ; Tue, 30 Mar 2010 08:42:26 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2U8gQNO010436 for ; Tue, 30 Mar 2010 08:42:26 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o2U8gQPv010435; Tue, 30 Mar 2010 08:42:26 GMT (envelope-from nobody) Message-Id: <201003300842.o2U8gQPv010435@www.freebsd.org> Date: Tue, 30 Mar 2010 08:42:26 GMT From: Fedor Dikarev To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/145194: Changed output of sockstat for AF_INET6 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 08:50:04 -0000 >Number: 145194 >Category: bin >Synopsis: Changed output of sockstat for AF_INET6 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 30 08:50:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Fedor Dikarev >Release: 6.x, 7.x and 8.x >Organization: Rambler >Environment: FreeBSD net.park.rambler.ru 7.2-STABLE FreeBSD 7.2-STABLE #1: Tue Jun 2 10:49:29 MSD 2009 root@net.park.rambler.ru:/usr/obj/usr/src/sys/MNGMT amd64 >Description: It's very hard to distinguish where local address and port ends and foreign address and port starts from sockstat output when using IPv6 addressess. One space between is enough as I think. >How-To-Repeat: root:net{R}[125] sockstat$ sockstat -6 www nginx 58211 9 tcp6 2a02:6b0:1:0:21a:92ff:fe80:f032:802a02:6b0:16:0:10cb:d0b0:7274:4cde:1145 .. and more such lines >Fix: Just add one space after local address and port. And get output like this: root:net{R}[135] sockstat$ sockstat -6 www nginx 58211 12 tcp6 2a02:6b0:1:0:21a:92ff:fe80:f032:80 2a02:6b0:16:0:10cb:d0b0:7274:4cde:1170 Patch attached with submission follows: --- sockstat.c 2010-03-30 12:37:25.000000000 +0400 +++ sockstat.c.orig 2010-03-30 12:22:06.000000000 +0400 @@ -609,7 +609,6 @@ case AF_INET: case AF_INET6: pos += printaddr(s->family, &s->laddr); - if((AF_INET6 == s->family) && (pos>=58)) { xprintf(" "); } while (pos < 58) pos += xprintf(" "); pos += printaddr(s->family, &s->faddr); >Release-Note: >Audit-Trail: >Unformatted: