From owner-svn-src-all@freebsd.org  Tue May 22 04:08:09 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40D4BEE5409;
 Tue, 22 May 2018 04:08:09 +0000 (UTC)
 (envelope-from araujo@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E80FD815DF;
 Tue, 22 May 2018 04:08:08 +0000 (UTC)
 (envelope-from araujo@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C920B6F2E;
 Tue, 22 May 2018 04:08:08 +0000 (UTC)
 (envelope-from araujo@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w4M488c4020316;
 Tue, 22 May 2018 04:08:08 GMT (envelope-from araujo@FreeBSD.org)
Received: (from araujo@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w4M4889c020315;
 Tue, 22 May 2018 04:08:08 GMT (envelope-from araujo@FreeBSD.org)
Message-Id: <201805220408.w4M4889c020315@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: araujo set sender to
 araujo@FreeBSD.org using -f
From: Marcelo Araujo <araujo@FreeBSD.org>
Date: Tue, 22 May 2018 04:08:08 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r334016 - head/usr.sbin/bhyve
X-SVN-Group: head
X-SVN-Commit-Author: araujo
X-SVN-Commit-Paths: head/usr.sbin/bhyve
X-SVN-Commit-Revision: 334016
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 04:08:09 -0000

Author: araujo
Date: Tue May 22 04:08:08 2018
New Revision: 334016
URL: https://svnweb.freebsd.org/changeset/base/334016

Log:
  We must free the variable str.
  
  Spotted by:	clang's static analyzer
  Submitted by:	Tom Rix <trix_juniper.net>
  Reviewed by:	grehan
  MFC after:	4 weeks
  Sponsored by:	iXsystems Inc.
  Differential Revision:	https://reviews.freebsd.org/D10009

Modified:
  head/usr.sbin/bhyve/pci_emul.c

Modified: head/usr.sbin/bhyve/pci_emul.c
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.c	Tue May 22 03:57:32 2018	(r334015)
+++ head/usr.sbin/bhyve/pci_emul.c	Tue May 22 04:08:08 2018	(r334016)
@@ -231,8 +231,7 @@ pci_parse_slot(char *opt)
 	si->si_funcs[fnum].fi_param = config;
 
 done:
-	if (error)
-		free(str);
+	free(str);
 
 	return (error);
 }