Date: Tue, 16 Dec 2014 19:43:55 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Alex Kozlov <ak@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r374800 - head/Mk/Uses Message-ID: <5490DFDB.5080000@FreeBSD.org> In-Reply-To: <20141216142422.GA38033@FreeBSD.org> References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> <20141216141320.GA28332@ravenloft.kiev.ua> <20141216142422.GA38033@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FvVU2EVgNkjiIsGas42PMcRnmjvjqrcRW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote: > On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote: >> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote: >>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak@FreeBSD.org> w= rote: >>> | Allow me to ask, why it should be 8 and not 4? >>> >>> Because a tabulation is 8 spaces. It should be consistent over the w= hole >>> ports tree. >> >> Well, 'Please view me with 4 column tabs!' line was added to bsd.port.= mk >> more than 20 year ago, in rev 69, because it's inconvenient to view it= with >> default tabulation value: many wrapped lines, indentation too deep, et= c. >=20 > I think I agree with Alex here. While most of us prefer ts=3D8, I don'= t see > the need to reindent some files, most notably b.p.m., as it will comple= tely > jeopardize its history and make 'svn blame' basically useless. >=20 > Even with editors that cannot grok ex:ts=3DX hints, its not that hard t= o do it > manually every time you need to view/edit these files. I do it all the= time > with nvi(1). >=20 > ./danfe >=20 As a vendor who maintains a forked ports tree, I despise this commit and all of the ones below. It makes carrying out customizations very difficult. Yes, it doesn't *look* good on the eyes, but reindenting on such large files with large history maintained by > 1 person is a sin. r358259 | bapt | 2014-06-18 07:22:20 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358258 | bapt | 2014-06-18 07:21:35 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358255 | bapt | 2014-06-18 07:20:53 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358237 | bapt | 2014-06-18 04:43:38 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358236 | bapt | 2014-06-18 04:41:25 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358220 | bapt | 2014-06-18 02:30:24 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358219 | bapt | 2014-06-18 02:28:44 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358218 | bapt | 2014-06-18 02:26:25 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358217 | bapt | 2014-06-18 02:20:29 -0500 (Wed, 18 Jun 2014) | 2 lines tabspace: 8 ------------------------------------------------------------------------ r358215 | bapt | 2014-06-18 02:17:13 -0500 (Wed, 18 Jun 2014) | 2 lines Switch to tabspace: 8 ------------------------------------------------------------------------ r358214 | bapt | 2014-06-18 02:14:22 -0500 (Wed, 18 Jun 2014) | 2 lines Switch to default tabspace: 8 ------------------------------------------------------------------------ r358213 | bapt | 2014-06-18 02:13:26 -0500 (Wed, 18 Jun 2014) | 2 lines Switch back to default tabspace: 8 --=20 Regards, Bryan Drewery --FvVU2EVgNkjiIsGas42PMcRnmjvjqrcRW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUkN/bAAoJEDXXcbtuRpfP62YIAMdzD+UEPJ0aQ8h7SoNwbyo0 ahIgAcLFBtOmCkVvwi3tkAOAB9X0sgUPccXlfhMDy6q18lYoV2j3vw4qxTHLgFbz 3JCvo1IcRoXj/HWX8kzf+7J2LWiwUI0jsbycFtPB1xoUA+3h4ODFsCXdK0Btt/7E AFa7sPVNtPMehn1v2N8TmiFTl7oNS1hjVFiioSU2tgZMyEcTHpsN12jqPvi3cmz8 C1mmHin38Q+84iS+88x5od6rh0U2EbKjTCm0zTJQR8SXi13SgV5DS8UHE+1oAdLf pQJOw5ovda5w7sOIyu0pP5uu9viB7ic/TCjEhfAsKEv9b/2gRio2pJnjMOoaKP0= =aSub -----END PGP SIGNATURE----- --FvVU2EVgNkjiIsGas42PMcRnmjvjqrcRW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5490DFDB.5080000>