From owner-freebsd-current@freebsd.org Sun Dec 29 22:31:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EEC01ECDDD for ; Sun, 29 Dec 2019 22:31:30 +0000 (UTC) (envelope-from wingairak@gmail.com) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mFf900Xtz4Cdn for ; Sun, 29 Dec 2019 22:31:28 +0000 (UTC) (envelope-from wingairak@gmail.com) Received: by mail-lj1-x242.google.com with SMTP id h23so31696218ljc.8 for ; Sun, 29 Dec 2019 14:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jdcQVGvjA1WLU+B2e6wiQEXaFJ3zs9PJENTzAKeaztg=; b=HEywTEcZechkMgRn+/dSpjlDV45kn1LJ0klQqcXK7p2B3ZZd5hEMENko66bchuOWjZ kzw5Yn8F2Y4BrhO1Vm31KNMWDd1VDDle7l4vRWF1F7kAvhrb3oqhJhD1bmXbmM2POqwI mGx3ig94soxHm4yqM92AC4VVhO6Yex0HCbna5dBIHiuKLtjN24pP5+m13SnBnlFagy4E hVwfz7VUT69zYKSjF0IFzTB2nBXfbbpkExOgK030btoVQ7e+X4KEA+kY08Wfmh+J7PpF RCSGPxV00pFdThCiTDSkkCBmm+TxnEvEWB2X+tL2s16mGwPEoOoAfdHvl0W8BNlSi7/1 LqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jdcQVGvjA1WLU+B2e6wiQEXaFJ3zs9PJENTzAKeaztg=; b=s2Onet7JJZtHBWm3Y0yxeyc7jqVfN7LJaHHhgGi6vdgQk+yPQRMo4SR2unjYUiw5W2 QiW8RJlifOtCmGO62wVtl5IHLq1mjwraf6JGk11nMMZ4d+O/lXsFRMEsQVfnaNTXwnud 5As7RwkCs1FU9on7j2+YtQmNRYeNOmprZUXBZTR8FuqgxNL52rz3gu1IT9ya7rlr8E34 P2+wAinqBb76ebomGzt6BWUygRJ4ADPDyEMhalsLSt12iHMfGZC/W24TyoQNs+5CYTgW +1bTUfqYE08qPzq3/4Ty4Jl69Opijl8Yn237Xfjy3slFHBJX4UPXHUKYDpauw3FxmlLm /+AQ== X-Gm-Message-State: APjAAAVavdISHOJ0c6ozcamYKkP/N8f/+wlAU9i01wcJnM1TgFqwew1T 1Evc+KyckVWfNGrwtevPsPCRAv2pYOv8ytXrX8WEJb9p X-Google-Smtp-Source: APXvYqwLXHI2fm7+OikPeu0N+teP4hA0rSyEPUdhvckHzpMz3HcZHS3li/EgDE2MSbUAtzKfxD9Vx4Ww54DLoHLBAsM= X-Received: by 2002:a2e:86c4:: with SMTP id n4mr35590471ljj.97.1577658687394; Sun, 29 Dec 2019 14:31:27 -0800 (PST) MIME-Version: 1.0 Received: by 2002:ac2:47fc:0:0:0:0:0 with HTTP; Sun, 29 Dec 2019 14:31:26 -0800 (PST) In-Reply-To: References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> From: Robert Wing Date: Sun, 29 Dec 2019 13:31:26 -0900 Message-ID: Subject: Re: OpenSSL breaks factor(6) To: Garance A Drosehn Cc: Steve Kargl , "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 47mFf900Xtz4Cdn X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=HEywTEcZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of wingairak@gmail.com designates 2a00:1450:4864:20::242 as permitted sender) smtp.mailfrom=wingairak@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[5]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (2.68), ipnet: 2a00:1450::/32(-2.64), asn: 15169(-1.87), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:31:30 -0000 Have y'all ever seen reviews.freebsd.org? On Sunday, December 29, 2019, Garance A Drosehn wrote: > On 29 Dec 2019, at 2:17, Steve Kargl wrote: > > > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > >>> > >>> An interested user will need to add that support. AFAIK, factor(6) > >>> has never recognized the 0x prefix, and I'm not trying to add new > >>> features. I'm simply fixing factor(6) to match its documentation, > >>> and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > >>> same results where applicable. > >> > >> Well, I'd be willing to do the work to add the new feature, and also > >> make the commit. It'd be a nice easy task for me to tackle... :) > >> > >> But I think documenting that "hex works, but only for hex values > >> which have at least one A-F in the value" is not something that I'd > >> want to draw attention to via documentation. > >> > > > > You have a 17 year history to worry about as hexadecimal support > > was added by "r104720 | fanf | 2002-10-09". Compiling factor(6) > > with and without OpenSSL support after 2002-10-09 gives a utility > > with different inconsistent behavior. > > If I understand you right, that behavior has not been documented > for 17 years. If it continues to be un-documented, that cannot > possibly break any scripts. I'm not saying we should remove the > behavior, I'm just saying we don't need to document it. Especially > not if we add support for a better way to specify hex values. > > On 29 Dec 2019, at 1:50, Steve Kargl wrote: > > > > Do what you want with the patch (including ignoring it). > > Hopefully, someone in the FreeBSD project will now > > recognize that factor(6) with and without OpenSSL gives > > inconsistent results, and neither matches factor(6)'s > > manpage. > > Oh. I tend to lose track with who is and isn't a src-committer on > FreeBSD. I've seen your name enough that I assumed you were one. > If you're not, I can handle committing these changes, including the > new feature. That'll keep my commit bit alive for another year! > > -- > Garance Alistair Drosehn = drosih@rpi.edu or gad@FreeBSD.org > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >