From owner-freebsd-current Sun Feb 24 1:20:22 2002 Delivered-To: freebsd-current@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id 91C3437B402; Sun, 24 Feb 2002 01:20:14 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020224092014.RMKK1147.rwcrmhc52.attbi.com@InterJet.elischer.org>; Sun, 24 Feb 2002 09:20:14 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id BAA82368; Sun, 24 Feb 2002 01:06:47 -0800 (PST) Date: Sun, 24 Feb 2002 01:06:46 -0800 (PST) From: Julian Elischer To: Jake Burkholder Cc: John Baldwin , dillon@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: First (easy) td_ucred patch In-Reply-To: <20020224040041.C35990@locore.ca> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I'm just saying that if this is the "simple p->p_ucred => td->td_ucred change that do only that and do the rewrite in a separate commit.. I'm not against doing hte commit as is however.. it's only 3 small nits.. the one that may be real is the other one I mention (I think in another email) where the capability of coping with a NULL td is lost. On Sun, 24 Feb 2002, Jake Burkholder wrote: > Apparently, On Sat, Feb 23, 2002 at 11:21:24AM -0800, > Julian Elischer said words to the effect of; > > > > > > > On Fri, 22 Feb 2002, John Baldwin wrote: > > > > > > > > http://www.FreeBSD.org/~jhb/patches/ucred.patch > > > > > > the structural rewriting in kern_proc.c should be done as a separate > > commit. (though I agree it should be done) > > > > the structural rewriting in kern/sysv_*.c > > could be done as a separate commit as well. > > (I agree it is worth doing) > > > > I'll let you get away with unp_listen() :-) > > I'd like to point out that in all cases that you mention, the original > structure before the "giant pushdown" is being restored. A lot of structural > rewriting occured in those commits. It was not done separately. I don't > recall if the patches were posted for review, I certainly never saw them. > > This strikes me as a double standard. > > Jake > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message