From owner-freebsd-usb@FreeBSD.ORG Tue Mar 1 10:03:57 2011 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7532F106564A for ; Tue, 1 Mar 2011 10:03:57 +0000 (UTC) (envelope-from k0802647@telus.net) Received: from defout.telus.net (outbound04.telus.net [199.185.220.223]) by mx1.freebsd.org (Postfix) with ESMTP id 2A2438FC14 for ; Tue, 1 Mar 2011 10:03:56 +0000 (UTC) Received: from edtncm03 ([199.185.220.221]) by priv-edtnes26.telusplanet.net (InterMail vM.8.01.03.00 201-2260-125-20100507) with ESMTP id <20110301100355.FKKZ24858.priv-edtnes26.telusplanet.net@edtncm03> for ; Tue, 1 Mar 2011 03:03:55 -0700 Received: from oliver.bc.lan ([66.183.53.162]) by edtncm03 with bizsmtp id Dm3v1g00x3VzCbE01m3vo5; Tue, 01 Mar 2011 03:03:55 -0700 X-Authority-Analysis: v=1.1 cv=/MstOKohVXLcoh41OzLGLG1pGanowbNkwUlbTYXu0H8= c=1 sm=2 a=Eg2Q673f0N8A:10 a=8nJEP1OIZ-IA:10 a=tD_ezVNOa0lw4AykoTcA:9 a=NfM9Fdlzk_VqVpdtQ9sA:7 a=GPUAAZq7B-U1Skx4iQf2L_D83SgA:4 a=wPNLvfGTeEIA:10 Received: from [10.111.111.113] (unknown [10.111.111.113]) by oliver.bc.lan (Postfix) with ESMTP id 1E7C66455; Tue, 1 Mar 2011 02:03:55 -0800 (PST) Message-ID: <4D6CC48A.9020004@telus.net> Date: Tue, 01 Mar 2011 02:03:54 -0800 From: Carl User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Hans Petter Selasky References: <4D6C829F.6090709@telus.net> <51ED50BF-C3B2-42C5-8E8A-D88DCC266EF6@gsoft.com.au> <201103010933.39054.hselasky@c2i.net> <201103010946.14791.hselasky@c2i.net> In-Reply-To: <201103010946.14791.hselasky@c2i.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-usb@freebsd.org Subject: Re: why does ulpt depend on ucom? X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2011 10:03:57 -0000 On 2011-03-01 12:46 AM, Hans Petter Selasky wrote: > On Tuesday 01 March 2011 09:33:38 Hans Petter Selasky wrote: >> On Tuesday 01 March 2011 07:31:00 Daniel O'Connor wrote: >>> On 01/03/2011, at 15:52, Carl wrote: >>>> /usr/src/sys/conf/files causes the ucom driver to be compiled into the >>>> kernel if ulpt is specified for inclusion. Why? ucom provides support >>>> for USB tty. >>> >>> Looks like a bug, specifically the second to last line of >>> /usr/src/sys/dev/usb/serial/ulpt.c >> >> You are right. >> >>> Also, I'm not really sure why ulpt.c is in the serial directory but that >>> isn't a big issue. It's not going to affect anyone very much, but it seems to me that it should be moved since it's rather misleading. > Please try the attached patch and report back. The kernels I'm building all require ucom for other reasons and don't include ulpt, so that patch wouldn't get tested by my builds. Hopefully someone else can test your patch. I spotted the issue only because I was trying to figure out how ucom gets into the GENERIC kernel despite the lack of "device ucom" appearing anywhere in the kernel configuration file. There are no less than 13 different man pages that incorrectly state that "device ucom" is necessary even though /usr/src/sys/conf/files makes that untrue. Since I didn't know about /usr/src/sys/conf/files before, it took me a while to figure out how ucom was getting included in apparent contradiction to the documentation. The wrong man pages: # find /usr/src -name '*.4' -exec grep -H 'device ucom' {} \; | grep -v '/ucom.4' /usr/src/share/man/man4/u3g.4:.Cd "device ucom" /usr/src/share/man/man4/uark.4:.Cd "device ucom" /usr/src/share/man/man4/ubsa.4:.Cd "device ucom" /usr/src/share/man/man4/uchcom.4:.Cd "device ucom" /usr/src/share/man/man4/ufoma.4:.Cd "device ucom" /usr/src/share/man/man4/uftdi.4:.Cd "device ucom" /usr/src/share/man/man4/uipaq.4:.Cd "device ucom" /usr/src/share/man/man4/umct.4:.Cd "device ucom" /usr/src/share/man/man4/umodem.4:.Cd "device ucom" /usr/src/share/man/man4/uplcom.4:.Cd "device ucom" /usr/src/share/man/man4/uslcom.4:.Cd "device ucom" /usr/src/share/man/man4/uvisor.4:.Cd "device ucom" /usr/src/share/man/man4/uvscom.4:.Cd "device ucom" BTW, am I missing something or is there truly no documentation for the format of /usr/src/sys/conf.files? Hans, do I need to submit bug reports for any of these things or will you just be checking in all the necessary fixes? Carl / K0802647