From owner-svn-src-head@freebsd.org  Thu Aug 11 16:59:57 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78C87BB68D5;
 Thu, 11 Aug 2016 16:59:57 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5A3AF180B;
 Thu, 11 Aug 2016 16:59:57 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id ECEC6B953;
 Thu, 11 Aug 2016 12:59:55 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Bjoern A. Zeeb" <bz@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r303963 - head/sys/powerpc/include
Date: Thu, 11 Aug 2016 09:40:12 -0700
Message-ID: <1743387.a2iKJ8FVcJ@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201608111506.u7BF6DX4046653@repo.freebsd.org>
References: <201608111506.u7BF6DX4046653@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 11 Aug 2016 12:59:56 -0400 (EDT)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Aug 2016 16:59:57 -0000

On Thursday, August 11, 2016 03:06:13 PM Bjoern A. Zeeb wrote:
> Author: bz
> Date: Thu Aug 11 15:06:12 2016
> New Revision: 303963
> URL: https://svnweb.freebsd.org/changeset/base/303963
> 
> Log:
>   Revert r303890 for now here as camdd fails to build on powerpc*
>   due to device_t only being available under _KERNEL.
>   
>   Reported by:	bde (_KERNEL in general), kib (build failure)
>   MFC after:	1 day
>   X-MFC with:	r303890

I think the real issue though is exposting this function prototype to
userland (I looked at it the other day).  camdd only wants bus_dma_segment_t.
It also explicitly includes <sys/bus_dma.h> which is a no-no.  I think this
should be fixed to either define a suitable bus_dma_segment_t explicitly
in libcam.h or the bus_dma headers have to all be audited to add
appropriate #ifdef _KERNEL guards.

-- 
John Baldwin