From owner-cvs-src@FreeBSD.ORG Mon Mar 27 08:07:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9F3416A400; Mon, 27 Mar 2006 08:07:04 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0825043D49; Mon, 27 Mar 2006 08:07:04 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 15B9C209D; Mon, 27 Mar 2006 10:06:57 +0200 (CEST) X-Spam-Tests: AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Learn: ham X-Spam-Score: -2.4/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id E22212081; Mon, 27 Mar 2006 10:06:56 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id C249833C8D; Mon, 27 Mar 2006 10:06:56 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: David Xu References: <200603270558.k2R5wwkB084458@repoman.freebsd.org> <864q1ktiw9.fsf@xps.des.no> Date: Mon, 27 Mar 2006 10:06:56 +0200 In-Reply-To: <864q1ktiw9.fsf@xps.des.no> (Dag-Erling =?iso-8859-1?Q?Sm=F8r?= =?iso-8859-1?Q?grav's?= message of "Mon, 27 Mar 2006 10:02:30 +0200") Message-ID: <86zmjcs44f.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 08:07:04 -0000 des@des.no (Dag-Erling Sm=F8rgrav) writes: > David Xu writes: > > Log: > > Comment out -g compiler option, found by 'FreeBSD Build Options Surve= y'. > You should simply remove it (users who want it can define DEBUG_FLAGS > in make.conf), and define WARNS instead of adding -Wall to CFLAGS. ...especially in light of the following: cc -O2 -pipe -march=3Dpentium4 -DPTHREAD_KERNEL -I/usr/src/lib/libthr/../li= bc/include -I/usr/src/lib/libthr/thread -I/usr/src/lib/libthr/../../includ= e -I/usr/src/lib/libthr/arch/i386/include -I/usr/src/lib/libthr/sys -I/usr/= src/lib/libthr/../../libexec/rtld-elf -I/usr/src/lib/libthr/../../libexec/r= tld-elf/i386 -I/usr/src/lib/libthr/../libthread_db -Winline -D_PTHREADS_INV= ARIANTS -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-pa= rameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-t= ype -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-par= ameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /us= r/src/lib/libthr/arch/i386/i386/pthread_md.c cc -O2 -pipe -march=3Dpentium4 -DPTHREAD_KERNEL -I/usr/src/lib/libthr/../li= bc/include -I/usr/src/lib/libthr/thread -I/usr/src/lib/libthr/../../includ= e -I/usr/src/lib/libthr/arch/i386/include -I/usr/src/lib/libthr/sys -I/usr/= src/lib/libthr/../../libexec/rtld-elf -I/usr/src/lib/libthr/../../libexec/r= tld-elf/i386 -I/usr/src/lib/libthr/../libthread_db -Winline -D_PTHREADS_INV= ARIANTS -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-pa= rameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-t= ype -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-par= ameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /us= r/src/lib/libthr/sys/thr_error.c In file included from /usr/src/lib/libthr/thread/thr_private.h:47, from /usr/src/lib/libthr/sys/thr_error.c:40: /usr/src/lib/libthr/../../include/stdio.h:415: warning: redundant redeclara= tion of '__isthreaded' /usr/src/lib/libthr/../libc/include/libc_private.h:46: warning: previous de= claration of '__isthreaded' was here In file included from /usr/src/lib/libthr/thread/thr_umtx.h:32, from /usr/src/lib/libthr/thread/thr_private.h:59, from /usr/src/lib/libthr/sys/thr_error.c:40: /usr/include/sys/umtx.h: In function `umtx_lock': /usr/include/sys/umtx.h:83: warning: passing arg 1 of `atomic_cmpset_int' f= rom incompatible pointer type /usr/include/sys/umtx.h:83: warning: passing arg 2 of `atomic_cmpset_int' m= akes integer from pointer without a cast /usr/include/sys/umtx.h:83: warning: passing arg 3 of `atomic_cmpset_int' m= akes integer from pointer without a cast /usr/include/sys/umtx.h: In function `umtx_trylock': /usr/include/sys/umtx.h:93: warning: passing arg 1 of `atomic_cmpset_int' f= rom incompatible pointer type /usr/include/sys/umtx.h:93: warning: passing arg 2 of `atomic_cmpset_int' m= akes integer from pointer without a cast /usr/include/sys/umtx.h:93: warning: passing arg 3 of `atomic_cmpset_int' m= akes integer from pointer without a cast /usr/include/sys/umtx.h: In function `umtx_timedlock': /usr/include/sys/umtx.h:102: warning: passing arg 1 of `atomic_cmpset_int' = from incompatible pointer type /usr/include/sys/umtx.h:102: warning: passing arg 2 of `atomic_cmpset_int' = makes integer from pointer without a cast /usr/include/sys/umtx.h:102: warning: passing arg 3 of `atomic_cmpset_int' = makes integer from pointer without a cast /usr/include/sys/umtx.h:103: warning: cast discards qualifiers from pointer= target type /usr/include/sys/umtx.h: In function `umtx_unlock': /usr/include/sys/umtx.h:112: warning: passing arg 1 of `atomic_cmpset_int' = from incompatible pointer type /usr/include/sys/umtx.h:112: warning: passing arg 2 of `atomic_cmpset_int' = makes integer from pointer without a cast /usr/include/sys/umtx.h:112: warning: passing arg 3 of `atomic_cmpset_int' = makes integer from pointer without a cast /usr/include/sys/umtx.h: In function `umtx_wait': /usr/include/sys/umtx.h:121: warning: cast discards qualifiers from pointer= target type In file included from /usr/src/lib/libthr/sys/thr_error.c:40: /usr/src/lib/libthr/thread/thr_private.h: At top level: /usr/src/lib/libthr/thread/thr_private.h:206: warning: function declaration= isn't a prototype /usr/src/lib/libthr/thread/thr_private.h:242: warning: function declaration= isn't a prototype /usr/src/lib/libthr/thread/thr_private.h:611: warning: redundant redeclarat= ion of '__isthreaded' /usr/src/lib/libthr/../../include/stdio.h:415: warning: previous declaratio= n of '__isthreaded' was here /usr/src/lib/libthr/thread/thr_private.h:618: warning: redundant redeclarat= ion of '_thr_initial' /usr/src/lib/libthr/arch/i386/include/pthread_md.h:97: warning: previous de= claration of '_thr_initial' was here *** Error code 1 Stop in /usr/src/lib/libthr. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no