From owner-freebsd-audit Sat Mar 23 1:15:11 2002 Delivered-To: freebsd-audit@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 036BC37B404; Sat, 23 Mar 2002 01:15:07 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g2N9F5D10825; Sat, 23 Mar 2002 09:15:05 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g2N9CqFc002263; Sat, 23 Mar 2002 09:12:52 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203230912.g2N9CqFc002263@grimreaper.grondar.org> To: Mike Barcroft Cc: audit@FreeBSD.ORG Subject: Re: chpass WARNS/lint fixes References: <20020322223555.I80338@espresso.q9media.com> In-Reply-To: <20020322223555.I80338@espresso.q9media.com> ; from Mike Barcroft "Fri, 22 Mar 2002 22:35:55 EST." Date: Sat, 23 Mar 2002 09:12:52 +0000 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > @@ -39,10 +39,11 @@ > > > > #ifndef lint > > static const char sccsid[] = "From: @(#)chpass.c 8.4 (Berkeley) 4/2/94"; > > -static const char rcsid[] = > > - "$FreeBSD: src/usr.bin/chpass/chpass.c,v 1.20 2002/03/22 01:19:26 imp Exp $"; > > #endif /* not lint */ > > The vendor ID should be restored from Rev 1.1 and then wrapped in > #if 0 ... #endif. There is a __FBSDID() a little later. Or are you talking about $Id$ from the original code? > > + > > +struct dom_binding {}; > > + > > This seems bogus; what is it used for? Nothing. It is bogus. :-) > The rest looks okay. Take 2 is on its way. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message