From owner-cvs-all Tue Feb 11 21:33:48 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FF0037B405; Tue, 11 Feb 2003 21:33:46 -0800 (PST) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38DB943F75; Tue, 11 Feb 2003 21:33:45 -0800 (PST) (envelope-from gibbs@scsiguy.com) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by aslan.scsiguy.com (8.12.6/8.12.5) with ESMTP id h1C5XIOU084248; Tue, 11 Feb 2003 22:33:18 -0700 (MST) (envelope-from gibbs@scsiguy.com) Date: Tue, 11 Feb 2003 22:33:18 -0700 From: "Justin T. Gibbs" To: Scott Long , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 busdma_machdep.c src/sys/i386/include bus_dma.h src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/include bus.h src/sys/sparc64/include bus.h iommuvar.h src/sys/sparc64/pci psycho.c src/sys/sparc64/sbus ... Message-ID: <2218062704.1045027998@aslan.scsiguy.com> In-Reply-To: <200301290725.h0T7PRK6066218@repoman.freebsd.org> References: <200301290725.h0T7PRK6066218@repoman.freebsd.org> X-Mailer: Mulberry/3.0.1 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > scottl 2003/01/28 23:25:27 PST > > Modified files: > sys/i386/i386 busdma_machdep.c > sys/i386/include bus_dma.h > sys/alpha/alpha busdma_machdep.c > sys/alpha/include bus.h > sys/sparc64/include bus.h iommuvar.h > sys/sparc64/pci psycho.c > sys/sparc64/sbus sbus.c > sys/sparc64/sparc64 bus_machdep.c iommu.c > Log: > Implement bus_dmamem_alloc_size() and bus_dmamem_free_size() as ... The commit message should have also indicated that bus_dmamem_*_size() are mearly crutches until the standard bus_dmamap_load() api on all architectures learns how to compact mappings to fit within the S/G requirements of the caller. Having an S/G list size of 1 is just a special case of this requirement. For the common case where more "static" mappings are required, bus_dmamem_alloc()/free() should still be used. Hopefully this crutch won't last very long as it just perpetuates bad usage of the bus dma api that will have to be cleaned up by, in all likelyhood, someone other than the driver/module maintainer that uses this API. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message