From owner-svn-src-head@freebsd.org Tue Oct 20 18:37:43 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCEA5A1A52B; Tue, 20 Oct 2015 18:37:43 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A06771EE; Tue, 20 Oct 2015 18:37:43 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id B906F1FE024; Tue, 20 Oct 2015 20:37:40 +0200 (CEST) Subject: Re: svn commit: r289633 - head/sys/ofed/include/linux To: John Baldwin References: <201510201602.t9KG2BeA079785@repo.freebsd.org> <1878746.bHLk1ML9QM@ralph.baldwin.cx> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Hans Petter Selasky Message-ID: <56268A5A.70103@selasky.org> Date: Tue, 20 Oct 2015 20:39:22 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1878746.bHLk1ML9QM@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 18:37:44 -0000 Hi, On 10/20/15 20:04, John Baldwin wrote: > On Tuesday, October 20, 2015 04:02:11 PM Hans Petter Selasky wrote: >> Author: hselasky >> Date: Tue Oct 20 16:02:11 2015 >> New Revision: 289633 >> URL: https://svnweb.freebsd.org/changeset/base/289633 >> >> Log: >> Add missing FreeBSD RCS keyword and SVN properties. >> >> Sponsored by: Mellanox Technologies >> >> Modified: >> head/sys/ofed/include/linux/io-mapping.h (contents, props changed) >> head/sys/ofed/include/linux/io.h (contents, props changed) >> head/sys/ofed/include/linux/jhash.h (contents, props changed) >> head/sys/ofed/include/linux/linux_compat.c (contents, props changed) >> head/sys/ofed/include/linux/linux_idr.c (contents, props changed) >> head/sys/ofed/include/linux/linux_radix.c (contents, props changed) >> head/sys/ofed/include/linux/vmalloc.h (contents, props changed) >> >> Modified: head/sys/ofed/include/linux/io-mapping.h >> ============================================================================== >> --- head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 15:28:02 2015 (r289632) >> +++ head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 16:02:11 2015 (r289633) >> @@ -1,3 +1,4 @@ >> +/* $FreeBSD$ */ >> /*- >> * Copyright (c) 2010 Isilon Systems, Inc. >> * Copyright (c) 2010 iX Systems, Inc. > > Just a note on style. Most headers put the tag below the license block like so > from : I'll fix that. > > /*- > * Copyright (c) 1997,1998,2003 Doug Rabson > * All rights reserved. > * > ... > > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > * > * $FreeBSD: head/sys/sys/bus.h 284088 2015-06-06 17:25:45Z marcel $ > */ > > It would have been nice to be more consistent with the rest of the tree. Maybe > look around next time to see if there is an existing style? > >> Modified: head/sys/ofed/include/linux/jhash.h >> ============================================================================== >> --- head/sys/ofed/include/linux/jhash.h Tue Oct 20 15:28:02 2015 (r289632) >> +++ head/sys/ofed/include/linux/jhash.h Tue Oct 20 16:02:11 2015 (r289633) >> @@ -18,6 +18,7 @@ >> * >> * I've modified Bob's hash to be useful in the Linux kernel, and >> * any bugs present are surely my fault. -DaveM >> + * $FreeBSD$ >> */ > > Please fix this one to leave a blank line before the tag at least. > I tried to make linux/jhash.h similar to dev/cxgb/common/jhash.h, which are actually duplicate files. --HPS