From owner-svn-src-all@freebsd.org Tue Mar 21 17:46:44 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE052D1678D; Tue, 21 Mar 2017 17:46:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C1CF91D2; Tue, 21 Mar 2017 17:46:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 3300A10A7DB; Tue, 21 Mar 2017 13:46:37 -0400 (EDT) From: John Baldwin To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Date: Tue, 21 Mar 2017 10:40:34 -0700 Message-ID: <1782817.djIc6TfI1t@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201703210639.v2L6dnRf055522@repo.freebsd.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 21 Mar 2017 13:46:37 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 17:46:45 -0000 On Tuesday, March 21, 2017 06:39:49 AM Gleb Smirnoff wrote: > Author: glebius > Date: Tue Mar 21 06:39:49 2017 > New Revision: 315662 > URL: https://svnweb.freebsd.org/changeset/base/315662 > > Log: > Hide struct inpcb, struct tcpcb from the userland. > > This is a painful change, but it is needed. On the one hand, we avoid > modifying them, and this slows down some ideas, on the other hand we still > eventually modify them and tools like netstat(1) never work on next version of > FreeBSD. We maintain a ton of spares in them, and we already got some ifdef > hell at the end of tcpcb. > > Details: > - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO. > - Make struct xinpcb, struct xtcpcb pure API structures, not including > kernel structures inpcb and tcpcb inside. Export into these structures > the fields from inpcb and tcpcb that are known to be used, and put there > a ton of spare space. > - Make kernel and userland utilities compilable after these changes. > - Bump __FreeBSD_version. > > Reviewed by: rrs, gnn > Differential Revision: D10018 First, this is a very good change and long overdue in divorcing the user-facing structure for live system reporting vs the kernel structure. However, I realize you don't use info from netstat when debugging kernel crash dumps, but other people _do_. It's ok if the kvm bits of netstat require a matching kernel and thus require recompiling everytime the ABI changes, but it is useful to have them. Please restore those. -- John Baldwin