From owner-svn-ports-all@freebsd.org  Wed Aug 30 09:31:01 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65D04DF3EC1;
 Wed, 30 Aug 2017 09:31:01 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3C64F64A62;
 Wed, 30 Aug 2017 09:31:01 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 7F1611D14B; Wed, 30 Aug 2017 09:31:00 +0000 (UTC)
Date: Wed, 30 Aug 2017 09:31:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r448936 - in head/cad/stepcode: . files
Message-ID: <20170830093100.GA32914@FreeBSD.org>
References: <201708291936.v7TJaH4W097098@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201708291936.v7TJaH4W097098@repo.freebsd.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Aug 2017 09:31:01 -0000

On Tue, Aug 29, 2017 at 07:36:16PM +0000, Kurt Jaeger wrote:
> New Revision: 448936
> URL: https://svnweb.freebsd.org/changeset/ports/448936
> 
> Log:
>   cad/stepcode: Fix portlint issues
>   
>   PR:		221835
> ...
>  CMAKE_ARGS+=	-DSC_INSTALL_PREFIX=${PREFIX} \
>  		-DSC_BUILD_TYPE=Release
> +
> +MANDIRS=	${PREFIX}/man

What does this variable do?  I don't see it referenced anywhere.  Looks
like someone tried to play pass MAN_DIR down to cmake, but failed to do
it properly (see below).

> @@ -0,0 +1,11 @@
> +--- doc/CMakeLists.txt.orig	2017-08-29 15:56:46 UTC
> ++++ doc/CMakeLists.txt
> +@@ -4,7 +4,7 @@ set(sc_MANS
> +   )
> + 
> + if(NOT DEFINED MAN_DIR)
> +-  set(MAN_DIR share/man)
> ++  set(MAN_DIR man)
> + endif(NOT DEFINED MAN_DIR)

Why to patch it when you can pass MAN_DIR via CMAKE_ARGS (together with
other values)?

./danfe