From owner-svn-src-all@freebsd.org Sat Oct 20 18:53:59 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5B56FF15F3 for ; Sat, 20 Oct 2018 18:53:58 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 662B78290B for ; Sat, 20 Oct 2018 18:53:58 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-ed1-x529.google.com with SMTP id c26-v6so34286968edt.3 for ; Sat, 20 Oct 2018 11:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+CXiIFzO/mGdx9DHuwwJhA2oSBUR3hzEkqUaUMrY8R4=; b=P/ZvAX+GZNIPkMWRYUrDmWgy5ZvIdoxy1R2mgHNTrEpRYQOPztD2IdRAw+sjYlPj+W 6+D2HeqI8+ae7QIZ57ESPAvTHvC8wYT1+/mrvB7k/AKpcV+uK9uTNmIG+n4XMd/B07A4 16w0oU+eFskuIiJ+Zjz+Bq7t974VxMtuw9vixkC6/xDUzslNG0wzyCPfnc6+DeMNVpvn oG+c1Rp1FZqEp/Z6P3jX96oEwdcvIAUSBJPmb5jwPryTR8ug6W4jWhWqr6LnJLNXFW4O FeZx1mArCTh7gd77E6cgjalMZ0XF8m4QDvLsi/0p4bt05spx1I8yseoZbsRr7IXgXLMW cPPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+CXiIFzO/mGdx9DHuwwJhA2oSBUR3hzEkqUaUMrY8R4=; b=ELIVYs7YECZl3jkzTyboZjZYrWbEC3ogaz6ZJDsFweqdfiQ6O1Y6R3L/5EnATIh83r 3+f2ETAyLIb+dC6I/RJgmfWPX0skA2PwiOP7a2g2QkPMoZw7X8z/L+x8A/NBSrvmPXuk FqIYm7e1iTHgzzFjKFgVmlIzRZUlm+ezTdMrwqvuaWRKojkLfWkq18syznW//GihcnJq J3Z/cP7WUp50IA3RKXlmzl+jaEHcbJNyDnPRDcAF5EuN5Xv1wE3899TpcGyD/bLbimde vrq7RxGHFINBUeK6KUepwno+ztLtE4SyAvnVKfbFS3r042/PeJi31k958GRt6bQTZL+m Nekg== X-Gm-Message-State: ABuFfogvOvX3NmfCzbmGINTnuCUO+0FFD3EapC+vUZxdMMQd6F4z61HF uelRmDacNqhT0Xbt1xK5kIxgsNkqAqwYS77Oi6EgJQ== X-Google-Smtp-Source: ACcGV603EhIczT5aGfaFQpsHVBwJTBw6/1JrtpAqtT+mZsTuE7z9tHRKazq1aCTJSG4TMiWq7aG60iPiTDC2TxVL63k= X-Received: by 2002:a50:a825:: with SMTP id j34-v6mr9642280edc.258.1540061636647; Sat, 20 Oct 2018 11:53:56 -0700 (PDT) MIME-Version: 1.0 References: <201810201831.w9KIVbtN043921@repo.freebsd.org> In-Reply-To: <201810201831.w9KIVbtN043921@repo.freebsd.org> From: Ed Schouten Date: Sat, 20 Oct 2018 20:53:31 +0200 Message-ID: Subject: Re: svn commit: r339468 - in head/sys: kern sys To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 18:53:59 -0000 Hi there, Op za 20 okt. 2018 om 20:31 schreef Conrad Meyer : > +static int > +sbuf_tty_drain(void *a, const char *d, int len) > +{ > + struct tty *tp; > + int rc; > + > + tp = a; > + > + if (kdb_active) { > + cnputsn(d, len); > + return (len); > + } > + if (tp != NULL && panicstr == NULL) { > + rc = tty_putstrn(tp, d, len); > + if (rc != 0) > + return (-ENXIO); > + return (len); > + } > + return (-ENXIO); > +} Disclaimer: Long time since I did a lot with the TTY code. Can kdb_active, tp == NULL and panicstr != NULL even occur in this case? tty_info() can only get called in non-degenerate cases, right? -- Ed Schouten