Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Feb 2012 00:41:47 +0400
From:      Andrey Zonov <andrey@zonov.org>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        Mikolaj Golub <trociny@freebsd.org>, Guy Helmer <ghelmer@palisadesystems.com>, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r230869 - head/usr.sbin/daemon
Message-ID:  <4F38240B.5040507@zonov.org>
In-Reply-To: <20120212200253.GC1355@garage.freebsd.pl>
References:  <20120205214647.GI30033@garage.freebsd.pl> <86sjiov29o.fsf@in138.ua3> <20120206082706.GA1324@garage.freebsd.pl> <86wr7zmy8f.fsf@kopusha.home.net> <20120206221742.GA1336@garage.freebsd.pl> <86liodu3me.fsf@in138.ua3> <20120208090600.GA1308@garage.freebsd.pl> <86sjihsln4.fsf@kopusha.home.net> <4F365C10.5050607@zonov.org> <861upz6fcg.fsf@kopusha.home.net> <20120212200253.GC1355@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On 13.02.2012 0:02, Pawel Jakub Dawidek wrote:
> On Sun, Feb 12, 2012 at 09:06:55PM +0200, Mikolaj Golub wrote:
>>   AZ>  Check return code from pidfile_write() function.  I saw many times
>>   AZ>  when pid could not be written because of there is not enough free
>>   AZ>  space (but file was created).  Unfortunately, I have no suggestions
>>   AZ>  how to handle this properly.
>>
>> We could return with error in this case (for me this almost the same as if we
>> don't create file at all). But if we check pidfile_write() status we should
>> resign the pidfile_write() feature that allows to pass NULL pidfh and check if
>> pidfile option is used. Something like in this patch:
>>
>> http://people.freebsd.org/~trociny/daemon/daemon.pidfile_write.1.patch
>>
>> Not sure I should commit this though.
>
> Please don't. Even if you can't write the pidfile, you should run the
> service. The same as for pidfile_open() failure as documented in
> example. Feel free to warn about problem with writing to pidfile, but
> don't treat it as critial error.

The problem is the following you cannot stop such a service with 
standard rc.d script and empty pidfile.

>
> We can also add such a warning to the example in the manual page.
>

-- 
Andrey Zonov



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F38240B.5040507>