From owner-cvs-all Sat Jan 6 5:24:50 2001 From owner-cvs-all@FreeBSD.ORG Sat Jan 6 05:24:47 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from garm.bart.nl (garm.bart.nl [194.158.170.13]) by hub.freebsd.org (Postfix) with ESMTP id 56FE237B400; Sat, 6 Jan 2001 05:24:46 -0800 (PST) Received: from daemon.chronias.ninth-circle.org (root@cable.ninth-circle.org [195.38.232.6]) by garm.bart.nl (8.10.1/8.10.1) with ESMTP id f06DOgo64031; Sat, 6 Jan 2001 14:24:42 +0100 (CET) Received: (from asmodai@localhost) by daemon.chronias.ninth-circle.org (8.11.1/8.11.0) id f06DCil00607; Sat, 6 Jan 2001 14:12:44 +0100 (CET) (envelope-from asmodai) Date: Sat, 6 Jan 2001 14:12:44 +0100 From: Jeroen Ruigrok van der Werven To: Alexander Langer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/s3 Makefile Message-ID: <20010106141244.A383@daemon.ninth-circle.org> References: <200101060944.f069iUU78655@freefall.freebsd.org> <20010106125323.A2966@cichlids.cichlids.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010106125323.A2966@cichlids.cichlids.com>; from alex@big.endian.de on Sat, Jan 06, 2001 at 12:53:23PM +0100 Organisation: Ninth-Circle Enterprises Sender: asmodai@wxs.nl Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20010106 13:00], Alexander Langer (alex@big.endian.de) wrote: >Thus spake Jeroen Ruigrok van der Werven (asmodai@FreeBSD.org): > >> We don't use += for SRCS in Makefiles, we simply use the >> line continuation character and state the rest of the sourcefiles >> on the next line. > >Uhm: >alex:/sys/modules $ grep 'SRCS[^\t ]+=' */Makefile | wc -l > 38 Please look at those files before commenting, then you would have noted that most, if not all, of these Makefiles use the += only for inclusion due to #define's, which does make sense. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 There is time in life for everything... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message