From owner-cvs-all Thu Mar 7 3:12:28 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 163A337B405; Thu, 7 Mar 2002 03:12:25 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g27BCPB63751; Thu, 7 Mar 2002 03:12:25 -0800 (PST) (envelope-from obrien) Date: Thu, 7 Mar 2002 03:08:21 -0800 From: "David O'Brien" To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/dd args.c dd.c dd.h Message-ID: <20020307030821.C63484@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200202222051.g1MKp0386376@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200202222051.g1MKp0386376@freefall.freebsd.org>; from markm@FreeBSD.org on Fri, Feb 22, 2002 at 12:51:00PM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Feb 22, 2002 at 12:51:00PM -0800, Mark Murray wrote: > markm 2002/02/22 12:51:00 PST > > Modified files: > bin/dd args.c dd.c dd.h > Log: > Fix warnings inspired by lint, a commercial lint and WARNS=4. Why was this needed? -u_int ddflags; /* conversion options */ +u_int ddflags = 0; /* conversion options */ ddflags was *already* `0' as it was in the BSS. By initializing it, you moved it into the data section which takes up more room in the binary. (unless the compiler is smart enough to notice the initizliation is to `0' and puts it back into the BSS). Granted one int is not going to break the disk space bank. But you are making arbitrary changes to good working code with decades of proven use. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message