From owner-svn-src-all@FreeBSD.ORG  Wed Nov 19 14:11:23 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0498814C
 for <svn-src-all@freebsd.org>; Wed, 19 Nov 2014 14:11:23 +0000 (UTC)
Received: from ost.citrin.ru (ost.citrin.ru [193.169.234.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AEDE1C8B
 for <svn-src-all@freebsd.org>; Wed, 19 Nov 2014 14:11:22 +0000 (UTC)
Received: from citrin.office.vega.ru (office-nat.spylog.net [193.169.234.6])
 (Authenticated sender: citrin@citrin.ru)
 by ost.citrin.ru (Postfix) with ESMTPSA id 378C0E0F803
 for <svn-src-all@freebsd.org>; Wed, 19 Nov 2014 14:11:14 +0000 (UTC)
Message-ID: <546CA502.4020008@citrin.ru>
Date: Wed, 19 Nov 2014 17:11:14 +0300
From: Anton Yuzhaninov <citrin@citrin.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
 rv:17.0) Gecko/20130516 Thunderbird/17.0.6
MIME-Version: 1.0
To: svn-src-all@freebsd.org
Subject: Re: svn commit: r274710 - head/sbin/ifconfig
References: <201411191357.sAJDvexm004236@svn.freebsd.org>
In-Reply-To: <201411191357.sAJDvexm004236@svn.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrin.ru; s=s0;
 t=1416406274; bh=GWncNfCN+/bADla09yTQZuYIznP4wHKxvEDCL85LKJM=;
 h=Message-ID:Date:From:MIME-Version:To:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=oMn1pw35xk6N6B4k8EYKdWX5Rgp2c6cVyyilIX+HhBPHEru0nY+HIItoDHUhEW2ohSHj8MVmjRp4TgsJ5n19q1rKCnvmqpWTNPdk6foLUeHfeRuU6btJ0ACi/BDLO1ET8lXt8+VYAKCYV4e/AP26ZegpijTjUclHvyC6m+P6EhQ=
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2014 14:11:23 -0000

On 11/19/14 16:57, Mark Felder wrote:
> New Revision: 274710
> URL: https://svnweb.freebsd.org/changeset/base/274710
>
> Log:
>    Expose groups by default in ifconfig output. This was never hidden by
>    OpenBSD; unsure why we chose to do so. As groups are a requirement for
>    pf, exposing them by default will make our pf implementation less
>    confusing.
...
>
> Modified: head/sbin/ifconfig/ifgroup.c
> ==============================================================================
> --- head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:31:08 2014	(r274709)
> +++ head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:57:39 2014	(r274710)
> @@ -86,9 +86,6 @@ getifgroups(int s)
>   	struct ifgroupreq	 ifgr;
>   	struct ifg_req		*ifg;
>
> -	if (!verbose)
> -		return;

Please return groups output under verbose flag.

pf is used not by all.

And more longer ifconfig output is unhandy. Especially on hosts with many 
interfaces.

Better to document ifconfig -v in pf.conf(5)