From owner-freebsd-stable@FreeBSD.ORG  Sat Mar  3 08:13:17 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B6A01065670;
	Sat,  3 Mar 2012 08:13:17 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe09.c2i.net [212.247.155.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 6ABD08FC0A;
	Sat,  3 Mar 2012 08:13:16 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [176.74.212.201] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.2)
	with ESMTPA id 72186650; Sat, 03 Mar 2012 09:13:08 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "Jung-uk Kim" <jkim@freebsd.org>,
 freebsd-usb@freebsd.org
Date: Sat, 3 Mar 2012 09:11:29 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.3-PRERELEASE; KDE/4.4.5; amd64; ; )
References: <20120227152238.GA2940@regency.nsu.ru>
	<20120302085012.GA25811@regency.nsu.ru>
	<201203021425.34456.jkim@FreeBSD.org>
In-Reply-To: <201203021425.34456.jkim@FreeBSD.org>
X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp
	|U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI
	-%GU9V5]iUZF&nRn9mJ'?&>O
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201203030911.29633.hselasky@c2i.net>
Cc: Alexey Dokuchaev <danfe@nsu.ru>, freebsd-stable@freebsd.org
Subject: Re: Resume broken in 8.3-PRERELEASE
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Mar 2012 08:13:17 -0000

On Friday 02 March 2012 20:25:32 Jung-uk Kim wrote:
> On Friday 02 March 2012 03:50 am, Alexey Dokuchaev wrote:
> > On Thu, Mar 01, 2012 at 04:55:03PM -0500, Jung-uk Kim wrote:
> > > It does not make a difference for me (i.e., usb suspend/resume
> > > still broken) but I think I found a typo:
> > > 
> > > --- sys/dev/usb/controller/usb_controller.c	(revision 232365)
> > > +++ sys/dev/usb/controller/usb_controller.c	(working copy)
> > > @@ -407,7 +407,7 @@ usb_bus_suspend(struct usb_proc_msg *pm)
> > > 
> > >  	USB_BUS_UNLOCK(bus);
> > > 
> > > -	bus_generic_shutdown(bus->bdev);
> > > +	bus_generic_suspend(bus->bdev);
> > > 
> > >  	usbd_enum_lock(udev);
> > 
> > Same thing here, does not seem to improve anything.  It might
> > suspend, resume (with keyboard working), then die on next suspend
> > completely.  Or it may die on the first suspend (without suspending
> > -- fans are spinning, screen is black and no response to anything
> > except hard power-off), this actually happens more often.
> 
> Try the attached patch.  At least, it fixed my problem.

Hi,

I've committed your patch with some minor modifications.

http://svn.freebsd.org/changeset/base/232448

Will you take care of the MFC to 8.3-RC + 8-stable?

--HPS