From owner-freebsd-apache@FreeBSD.ORG Mon Feb 24 14:30:58 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 143519FF; Mon, 24 Feb 2014 14:30:58 +0000 (UTC) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A0E961C75; Mon, 24 Feb 2014 14:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=hE1ZhsYH7la1e50oaTUT08UVLJdeGjsAJOUpiWVD73Y=; b=SQMI1OTbD6kuxVdb1D57xZZWl6+RrdUzRAW8NE0SWBgwsTQNSIiGUwJcidr7x4DE0F2mz3NH+pvESXMflqxPMsHlwZVGM3+3Ui1znYdLOxFHstrCXCycoNdEAjdN/FykdCQWYiWspkzlvUKQzL1Z4eB6woBj9SS1QgsZT7Zrr/d4XbSTawR4WjJ06u5GCcuXTkdIdeN7C2rCofemId7mHjrh9IrEAE3M7U5ipjW53oql1mgmTe2cQ/nDqDQmKmzWRTe2y+Q+UQtQPqKoRg1Tl61D7YXiq/6yB0abL1YRzAhqNWW0G0hgpLzpw+jWkcilnDpZk2A61FsUJjv3rWL9FnIKbW8/qC9NEMw2x6g45PIRxdPi2bNRhDrZrgrtvSQEPM734JzuNKBLj5kzqkneSeXb1pOti7dWau3+lhI1g7724PX/VC7Likzfe8v6UPosI5LDbLrZy31T84eatRI2AoARt1lgqePP7UKQHMKRnuNqvoBglTW3lgzQI7aQbg8JZp5BIW1UsZv/7+am8Y62fM15HF/89fDlmtx/1RlqPDQ/kM28F4GpKAC2MbbuIb9EjNr0OSdxsuzOa03fOJXWJ9uB+qFlNOSYKKW2rEhjqgUTouLG1Owq4nAVc1A+od+FiEVI7GEBv2maiiuG0ZL/an3uTMp3jUbCxYkEhZbtsrQ=; Received: from light.codelabs.ru (v-light.codelabs.ru [144.206.233.83]) by 0.mx.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1WHwYZ-000Jje-Go; Mon, 24 Feb 2014 18:30:55 +0400 Date: Mon, 24 Feb 2014 18:30:51 +0400 From: Eygene Ryabinkin To: Mathieu Arnold Subject: Re: Patch for devel/apr1 Message-ID: References: <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> Sender: rea@codelabs.ru Cc: apache@freebsd.org, portmgr@freebsd.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2014 14:30:58 -0000 --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mathieu, good day. Mon, Feb 24, 2014 at 02:40:34PM +0100, Mathieu Arnold wrote: > +--On 24 f=C3=A9vrier 2014 04:31:40 +0400 Eygene Ryabinkin > wrote: > | Sat, Feb 22, 2014 at 12:04:51PM +0400, Eygene Ryabinkin wrote: > |> Thu, Feb 20, 2014 at 11:16:40PM +0400, Eygene Ryabinkin wrote: > |> > Attached is the patch that fixes handling of WITH_/WITHOUT_ knobs > |> > (and may be something else). How to reproduce: set WITH_LDAP via > |> > make's command line and build apr1. You will end up with APR that > |> > doesn't support LDAP. Tested on port's HEAD@r343654. > |>=20 > |> Gentlemen? Is anyone around to look at this? > |=20 > | Involving portmgr. Gentlemen, devel/apr1 doesn't have OPTIONS_DEFINE s= et, > | so this breaks at least handling of WITH/WITHOUT options. Can I have > | approval for the patch? >=20 > Hum, no, I don't see why it would be needed. What does it fix ? Building with 'make WITH_LDAP=3Dyes', for example. It won't produce your LDAP-powered APR if you hadn't used 'make options' and selected LDAP there before. Do you familiar with http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.ht= ml section 5.12.2.2? Or, alternatively, with Mk/bsd.options.mk lines 178, {{{ ALL_OPTIONS:=3D ${OPTIONS_DEFINE:O:u} }}} and block starting at line 260 {{{ =2Efor opt in ${ALL_OPTIONS} =2Eif defined(WITH_${opt}) PORT_OPTIONS+=3D ${opt} =2Eendif =2Eif defined(WITHOUT_${opt}) PORT_OPTIONS:=3D ${PORT_OPTIONS:N${opt}} =2Eendif =2Eendfor }}} Citing by $FreeBSD: head/Mk/bsd.options.mk 344393 2014-02-15 14:33:39Z anto= ine $. Thanks. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlMLV5tfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PvT0QD/YMJZNz9JmvAyNAx70OG71OVS MLyZWXl43jf2wr5qlm4A/1chWpUYOOhoQuYB6pHE3uEjTMAU+hp3NtHCtDeAoKbp =ec9J -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--