Date: Tue, 31 Aug 1999 15:47:30 -0600 From: Warner Losh <imp@village.org> To: Nick Hibma <hibma@skylink.it> Cc: "Jeffrey J. Mountin" <jeff-ml@mountin.net>, John Hay <jhay@mikom.csir.co.za>, obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.1 rm.c Message-ID: <199908312147.PAA13885@harmony.village.org> In-Reply-To: Your message of "Tue, 31 Aug 1999 21:08:50 %2B0200." <Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it> References: <Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it> Nick Hibma writes:
: if ( !e || (fflag && errno == ENOENT)) {
Just to pick a style(9) nit, but the space before the ! is not
allowed.
: is equivalent to
: if (!(e=rmdir(p->fts_accpath)) || (fflag && errno == ENOENT)) {
: but does not hide the fact that the rmdir is executed in all cases.
If you are going to unhide all things like this, then you will have a
lot of work to do. There are hundreds of places in the tree that do
things like this. :-(
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908312147.PAA13885>