From owner-svn-src-head@freebsd.org Wed Oct 14 23:23:19 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E32E2A155B3 for ; Wed, 14 Oct 2015 23:23:18 +0000 (UTC) (envelope-from jlooney@juniper.net) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0123.outbound.protection.outlook.com [65.55.169.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 621E6EF8; Wed, 14 Oct 2015 23:23:17 +0000 (UTC) (envelope-from jlooney@juniper.net) Received: from BLUPR05MB1971.namprd05.prod.outlook.com (10.162.224.25) by BLUPR05MB1969.namprd05.prod.outlook.com (10.162.224.23) with Microsoft SMTP Server (TLS) id 15.1.300.14; Wed, 14 Oct 2015 23:23:15 +0000 Received: from BLUPR05MB1971.namprd05.prod.outlook.com ([10.162.224.25]) by BLUPR05MB1971.namprd05.prod.outlook.com ([10.162.224.25]) with mapi id 15.01.0300.010; Wed, 14 Oct 2015 23:23:15 +0000 From: Jonathan Looney To: Gleb Smirnoff , Hiren Panchasara CC: "svn-src-head@freebsd.org" Subject: Re: svn commit: r289276 - in head/sys: conf kern netinet sys Thread-Topic: svn commit: r289276 - in head/sys: conf kern netinet sys Thread-Index: AQHRBnTq2xtH3wfO1kqYjJDR3UuBVJ5rXpwA Date: Wed, 14 Oct 2015 23:23:15 +0000 Message-ID: References: <201510140035.t9E0ZbXS030094@repo.freebsd.org> <20151014113859.GS1023@FreeBSD.org> In-Reply-To: <20151014113859.GS1023@FreeBSD.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.6.150930 authentication-results: spf=none (sender IP is ) smtp.mailfrom=jlooney@juniper.net; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [66.129.241.13] x-microsoft-exchange-diagnostics: 1; BLUPR05MB1969; 5:bg4qaLNFK4ee/IJenrqXGWY/ioE0AWCkBFBdmRjIBaIfP4+4GRcRI6te3Q+zSTEJJD/78u7Abv9/uUVjegy+ZKM6YqT/vimsOjBnAEyxmWlga6AIWEQI+xdUHD8kYYjD3dQyWsD9U2GRKN2GmUPTwQ==; 24:TG12z+NTaGZ5+jG9Su+shf4Wry7e+sDlXEhKjDtQk7ghEkF1HBIxGgkQWx3RO9QadlqkaDaOEKre0rhiktQTGkc5Gb8GxirYieUjjD89VeU=; 20:tlp2+JTIJXwNJHvc2ozrWxNnJzvIjykrsyVrRtbdlVISw1/D+akukkxjMAhTur57o9mxdO06F/deRQ2cYl6MiA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR05MB1969; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001); SRVR:BLUPR05MB1969; BCL:0; PCL:0; RULEID:; SRVR:BLUPR05MB1969; x-forefront-prvs: 0729050452 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(199003)(479174004)(24454002)(189002)(377454003)(105586002)(5001960100002)(92566002)(5002640100001)(106356001)(106116001)(81156007)(99286002)(5001770100001)(2950100001)(10400500002)(46102003)(97736004)(4001350100001)(189998001)(5008740100001)(77096005)(450100001)(5007970100001)(83506001)(19580395003)(86362001)(76176999)(50986999)(19580405001)(11100500001)(54356999)(2900100001)(5004730100002)(101416001)(87936001)(40100003)(64706001)(36756003)(66066001)(102836002)(122556002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR05MB1969; H:BLUPR05MB1971.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <1A88F8EA1856DE4C80F97DBA6C6546B3@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2015 23:23:15.5714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB1969 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 23:23:19 -0000 On 10/14/15, 7:38 AM, "Gleb Smirnoff" wrote: >What if we write it down this way (thanks C11): > >struct tcpcb { > ... > union { >#ifdef TCPPCAP > struct { > struct mbufq t_inpkts; > struct mbufq t_outpkts; > }; >#endif > uint64_t _pad[6]; > } >}; > >So, compiler cares about pointer size, not us. And more readable, IMHO. Hi Gleb, Thanks! I agree. I'll include this in a cleanup patch that addresses the comments received after the commit. Jonathan