From owner-cvs-all  Tue Jan 22 18:23:16 2002
Delivered-To: cvs-all@freebsd.org
Received: from chez.McKusick.COM (chez.mckusick.com [209.31.233.177])
	by hub.freebsd.org (Postfix) with ESMTP
	id BCBAC37B400; Tue, 22 Jan 2002 18:23:10 -0800 (PST)
Received: from chez.McKusick.COM (localhost [127.0.0.1])
	by chez.McKusick.COM (8.11.6/8.11.6) with ESMTP id g0N2N1W64119;
	Wed, 23 Jan 2002 02:23:01 GMT
	(envelope-from freebsd@chez.McKusick.COM)
Message-Id: <200201230223.g0N2N1W64119@chez.McKusick.COM>
To: Benno Rice <benno@jeamland.net>
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_extern.h ffs_softdep.c 
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	mckusick@mckusick.com
In-Reply-To: Your message of "22 Jan 2002 23:08:52 +1200."
             <1011697733.442.0.camel@ratchet.jeamland.net> 
Date: Tue, 22 Jan 2002 18:23:01 -0800
From: FreeBSD Mail Account <freebsd@chez.McKusick.COM>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

I have added a stub routine for softdep_request_cleanup() to
ffs_softdep_stub.c to make the kernel compile without the
SOFTUPDATES option. I took this approach as it is the preferred
method for resolving missing soft updates functions. Sorry all
for breaking your kernels.

	Kirk McKusick

=-=-=-=-=-=

From: Benno Rice <benno@jeamland.net>
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_extern.h ffs_softdep.c
To: Kirk McKusick <mckusick@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200201220617.g0M6HOx41725@freefall.freebsd.org>
Message-Id: <1011697733.442.0.camel@ratchet.jeamland.net>


On Tue, 2002-01-22 at 18:17, Kirk McKusick wrote:
> mckusick    2002/01/21 22:17:24 PST
>
>   Modified files:
>     sys/ufs/ffs          ffs_alloc.c ffs_extern.h ffs_softdep.c
>   Log:
>   This patch fixes a long standing complaint with soft updates in
>   which small and/or nearly full filesystems would fail with `file
>   system full' messages when trying to replace a number of existing
>   files (for example during a system installation). When the allocation
>   routines are about to fail with a file system full condition, they
>   make a call to softdep_request_cleanup() which attempts to accelerate
>   the flushing of pending deletion requests in an effort to free up
>   space. In the face of filesystem I/O requests that exceed the
>   available disk transfer capacity, the cleanup request could take
>   an unbounded amount of time. Thus, the softdep_request_cleanup()
>   routine will only try for tickdelay seconds (default 2 seconds)
>   before giving up and returning a filesystem full error. Under typical
>   conditions, the softdep_request_cleanup() routine is able to free
>   up space in under fifty milliseconds.

This change breaks kernels without softupdates.

The attached patch fixes the problem.

--
Benno Rice
benno@jeamland.net

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message