Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Apr 2023 13:02:10 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6bd4bb9bdbad - main - mlx5en(4): Explain why CQE zipping is off.
Message-ID:  <202304181302.33ID2Awl079122@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by hselasky:

URL: https://cgit.FreeBSD.org/src/commit/?id=6bd4bb9bdbadb76c5502c7972df9f525b909e2f5

commit 6bd4bb9bdbadb76c5502c7972df9f525b909e2f5
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2023-04-18 11:12:32 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2023-04-18 13:01:07 +0000

    mlx5en(4): Explain why CQE zipping is off.
    
    MFC after:      1 week
    Sponsored by:   NVIDIA Networking
---
 sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
index ab0cf49c2e8a..7a11bedffb10 100644
--- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
+++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
@@ -3873,9 +3873,10 @@ mlx5e_build_ifp_priv(struct mlx5_core_dev *mdev,
 	priv->params.lro_wqe_sz = MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ;
 
 	/*
-	 * CQE zipping is currently defaulted to off. when it won't
-	 * anymore we will consider the HW capability:
-	 * "!!MLX5_CAP_GEN(mdev, cqe_compression)"
+	 * CQE zipping is off, because the per-packet 32-bit Toeplitz hash
+	 * is then not supported. The 32-bit Toeplitz hash is needed to
+	 * correctly demultiplex incoming traffic into the expected
+	 * network queues.
 	 */
 	priv->params.cqe_zipping_en = false;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304181302.33ID2Awl079122>