From owner-svn-src-head@freebsd.org Sat Mar 28 02:02:37 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6D82426B8D2; Sat, 28 Mar 2020 02:02:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48q26g5fFhz4QnM; Sat, 28 Mar 2020 02:02:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-oi1-x233.google.com with SMTP id v134so10560368oie.11; Fri, 27 Mar 2020 19:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=N4wpJWJNZ4EC+0dZ5Iag1JJtKdP+glwILTVf/fgi26E=; b=sgrhRY409vrcq/8uUoJ4ftNJpR5FHs/SVUwEb9mozAud3iTrtXvWi/mq3NoxsAjdHm lDpvgsU5cpFia59ErkS/dP+WO0liLgoVIsliwfrHKtLb72buvBWShg72YSWZWc3AmI9O /v+87A8BSH07MAARy9q66/lB0evZPIN4FbtFsi8PLYtm+YxF997Rg1AvEFxIPrpJkiLS x1iNJZ391OwLLyxjMZhUN4qrjBsMWPd7jAveaKt898Jm/sUIf/lFpdMznjyGVW+a6LBg e/lUmywAzzMvWRXgafpzWK0HJwxSI7s6GWVFQNpuX+ICaPghtM67QCc6fj+XsrTL3Gyu jWww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=N4wpJWJNZ4EC+0dZ5Iag1JJtKdP+glwILTVf/fgi26E=; b=Yx2uKGDnfI2wyMpk2DrxPwLkzfJwkPDMURXvXnIC9gKzFFRzmOlLBiIGyMlchlUi/p xpIkAWEm6gtVlx7/gfwHyBmJAhcb0KjKuOL2IJQcDVky9b5hHsYMzP/p4L+F9dlRpuAp BW831zfoZXXUKs4IrZt0QOoc2QH5SudoZrGBQHKHP9cuvdjzT3ZBF/w53mUqatWpllyB yT37BInYqRSpb/Cr5k77FKjxcYIqYvbxFD7kmlXaZygarC5zrGe8XiXAD8aO16t2F7Ki 7qG0GHS54+wP6OWxEUBEeVWW4S3HnMR+gT7bCR6Kx+aIYCyiK4tgjrEPeTljSI7NGtmo 4XZg== X-Gm-Message-State: ANhLgQ3xPen4RcSaaK8zvH47YE4tkmZ/KwWThPdLLXBfzmDoqDnDtcJN okFgw7dhwGxVyHV5bNDC0EOvNUm65uE= X-Google-Smtp-Source: ADFU+vt6+2CJsAqgYy4sFTej4NTASXLQE0HqF5vOwedDHBRpw1RVsOt0UVhnj+zYJQAx6Mle9hGuMw== X-Received: by 2002:a17:90a:5802:: with SMTP id h2mr2288269pji.141.1585359350113; Fri, 27 Mar 2020 18:35:50 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q8sm4560777pjq.28.2020.03.27.18.35.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2020 18:35:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r359385 - head/usr.bin/kyua From: Enji Cooper In-Reply-To: Date: Fri, 27 Mar 2020 18:35:48 -0700 Cc: Enji Cooper , src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: <62B0FBBE-9676-4DEC-B2C8-0FCB536094FC@gmail.com> References: <202003280108.02S18KWc062782@repo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48q26g5fFhz4QnM X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2020 02:02:37 -0000 > On Mar 27, 2020, at 6:33 PM, Ed Maste wrote: >=20 > On Fri, 27 Mar 2020 at 21:09, Enji Cooper wrote: >>=20 >> Author: ngie >> Date: Sat Mar 28 01:08:20 2020 >> New Revision: 359385 >> URL: https://svnweb.freebsd.org/changeset/base/359385 >>=20 >> Log: >> Check in the generated copies of the manpages >=20 > I think this is the wrong change for the issue reported by Julian H > Stacey, although I don't think having generated manpages committed to > the tree matters too much in practice. >=20 >> In the event that one's build environment doesn't define `$SH`, the = build >> will also fail until this change is introduced. >=20 > This isn't the case - the reported failure occurred because the > manbuild.sh script did not have +x set. My local builds and CI builds > were fine, without having SH defined. I understand, but I=E2=80=99d rather not rely on a script=E2=80=99= s mode, though. This is how build failures happen when the source tree = is checked out somewhere with -o noexec. Thanks, -Enji=