Date: Fri, 27 Mar 2020 18:35:48 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r359385 - head/usr.bin/kyua Message-ID: <62B0FBBE-9676-4DEC-B2C8-0FCB536094FC@gmail.com> In-Reply-To: <CAPyFy2A2sA-ZrpqPQKSpt7R_ZLs_kCUQRW44JfMfR2xC4%2BzTyQ@mail.gmail.com> References: <202003280108.02S18KWc062782@repo.freebsd.org> <CAPyFy2A2sA-ZrpqPQKSpt7R_ZLs_kCUQRW44JfMfR2xC4%2BzTyQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mar 27, 2020, at 6:33 PM, Ed Maste <emaste@freebsd.org> wrote: >=20 > On Fri, 27 Mar 2020 at 21:09, Enji Cooper <ngie@freebsd.org> wrote: >>=20 >> Author: ngie >> Date: Sat Mar 28 01:08:20 2020 >> New Revision: 359385 >> URL: https://svnweb.freebsd.org/changeset/base/359385 >>=20 >> Log: >> Check in the generated copies of the manpages >=20 > I think this is the wrong change for the issue reported by Julian H > Stacey, although I don't think having generated manpages committed to > the tree matters too much in practice. >=20 >> In the event that one's build environment doesn't define `$SH`, the = build >> will also fail until this change is introduced. >=20 > This isn't the case - the reported failure occurred because the > manbuild.sh script did not have +x set. My local builds and CI builds > were fine, without having SH defined. I understand, but I=E2=80=99d rather not rely on a script=E2=80=99= s mode, though. This is how build failures happen when the source tree = is checked out somewhere with -o noexec. Thanks, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?62B0FBBE-9676-4DEC-B2C8-0FCB536094FC>